Fix C++ export resource header ordering - #1674
Open
subotac wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C++ generator added exported resource class headers to the global include list, which is emitted before generated type definitions. As a result, a resource constructor using a generated record
could reference that type before it was defined.
Emit each generated resource header at its position in the topologically sorted header source while keeping the include outside the namespace. Add a code generation regression test for an exported
resource constructor that takes a record parameter.
Testing
cargo test --locked -p wit-bindgen-cppcargo test --locked --workspace --all-targets --exclude wit-bindgen-moonbitcargo clippy --locked --workspace --all-targets -- -D warningscargo fmt --all -- --check