Add compact import generation in wasm-smith - #2627
Open
chacailline wants to merge 2 commits into
Open
Conversation
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates wasm-smith to generate compact import sections.
Allows wasmtime fuzzing of compact import sections for bytecodealliance/wasmtime#14108.
Module::imports_exports_from_module_shapeandModule::arbitrary_imports_from_availableare also updated to accept compact imports and to generate them when it's enabled in the config.I enabled the proposal by default.
config.rshas a comment saying "Proposals that are not stage4+ are disabled by default." By that logic, we may want to enable wide arithmetic by default too.Outside of
#[cfg(feature = "component-model")],DuplicateImportsBehavior::Disallowedwas only ever created in an if-test inModule::arbitrary_imports, so I had to add a#[cfg]gate to pass CI.The binary format supports empty compact import statements, but it's not clear whether the text format will support them. See WebAssembly/compact-import-section#22. Currently,
wasmparserdoesn't accept them, butwasmprinteroutputs them if given a binary with empty statements.For now, I don't generate empty statements. If they're not allowed, we should update
wasmprinternot to generate them. If they are allowed, we should updatewasmparserto accept them, and probably generate them inwasm-smith.