Validate the size of defined component types - #2624
Open
alexcrichton wants to merge 1 commit into
Open
Conversation
This commit is an implementation of WebAssembly/component-model#688 where the in-memory size of component model types is now calculated and validated to be below the static threshold. The eventual goal of this implementation is to simplify logic in Wasmtime for example and reduce the affect/possibility of integer overflow when handling otherwise very large types. The limits here are large enough that all preexisting components are expected to continue to validate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is an implementation of WebAssembly/component-model#688 where the in-memory size of component model types is now calculated and validated to be below the static threshold. The eventual goal of this implementation is to simplify logic in Wasmtime for example and reduce the affect/possibility of integer overflow when handling otherwise very large types. The limits here are large enough that all preexisting components are expected to continue to validate.