allow type aliasing of DefinedType#209
Merged
fibonacci1729 merged 1 commit intoJun 30, 2026
Merged
Conversation
fibonacci1729
approved these changes
Jun 29, 2026
fibonacci1729
left a comment
fibonacci1729
left a comment
Collaborator
There was a problem hiding this comment.
Good catch! LGTM, thanks!
Contributor
Author
|
Thanks for the review @fibonacci1729, since there don't seem to be an objections can we go ahead and merge this? I have some in-flight work which I'd like to rebase on main with this fix if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #208
Currently
CompositionGraphEncoderassumes all type aliases targeting a DefinedType have previously been exported.This assumption does not hold true for inlined type alias definitions which causes a panic when CompositionGraphEncoder attempts to index a type which can't be found in the current scope.
To fix this we use an indirect lookup for the aliased type returning the previously issued id only when present in the current scope.