Update codegen - #240
Merged
Merged
Conversation
MendyBerger
force-pushed
the
update-codegen
branch
from
August 28, 2026 16:05
9c637f6 to
495d5ea
Compare
dicej
reviewed
Aug 28, 2026
dicej
left a comment
dicej
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for doing this (and for the excellent test coverage), @MendyBerger!
Looks good to me; my only concern is the remove_dir_all added to BindingsGenerator::generate, which could be a surprising change from the previous behavior. I'd prefer to avoid that and instead simply refuse to generate the bindings by default if the directory already exists (in which case the user can remove it themself), with an option to force the existing directory to be used if desired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #218
Implemented according to what was agreed upon in the following comments:
Since this is quite a lot of code, I've split it into 3 commits: