Skip to content

fix: keep injecting NODE_EXTRA_CA_CERTS/DENO_CERT when a build has no system CA store - #302

Merged
dash14 merged 3 commits into
mainfrom
fix/inspect-ca-injection-without-system-store
Aug 30, 2026
Merged

fix: keep injecting NODE_EXTRA_CA_CERTS/DENO_CERT when a build has no system CA store#302
dash14 merged 3 commits into
mainfrom
fix/inspect-ca-injection-without-system-store

Conversation

@dash14

@dash14 dash14 commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • inject() in the inspect engine's buildkit-runc wrapper aborted entirely when the rootfs had no system CA store (findSystemStore error), which also skipped setting NODE_EXTRA_CA_CERTS/DENO_CERT even though those don't need one.
  • Base images like node:*-slim have no OS CA store but Node itself does TLS fine normally (it uses its own bundled roots), so this only surfaced once the inspect engine tried to make the step trust the proxy's CA — e.g. corepack enable failing with SELF_SIGNED_CERT_IN_CHAIN.
  • Now only the variables that actually need the system store (REQUESTS_CA_BUNDLE, PIP_CERT, SSL_CERT_FILE, and the store itself as an append target) are skipped when it's absent; NODE_EXTRA_CA_CERTS/DENO_CERT still get their own dedicated CA file regardless.
  • Updated docs/inspect-engine.md's Limitations section to describe the new, narrower scope of this gap.

@dash14
dash14 merged commit d5b268a into main Aug 30, 2026
25 checks passed
@dash14
dash14 deleted the fix/inspect-ca-injection-without-system-store branch August 30, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant