Add file system access profile to execute response

[osjo-meroton]

Currently bb-portal uses the latest file system access profile saved to the FSAC. This profile may differ from the profile produced by the action being viewed, for example when viewing old action results. With this change, action result contains its corresponding access profile.

[EdSchouten]

The problem is that the profile can become pretty big. I don't think it's a good idea to attach tens of kilobytes of data.

[moroten]

The problem is that the profile can become pretty big. I don't think it's a good idea to attach tens of kilobytes of data.

The recommended maximum size is 64 kB, so yes it is quite a bit of data. The goal is to get the access profile for a specific action. One could store the profile in FSAC for both the reduced action digest and the full action digest. That would though fill up the FSAC and there is race condition between execution and access if multiple actions are run in parallel.

What about storing the profile in the CAS and reference it from the action result? Then it's just ~70 bytes of data.

[EdSchouten]

What about storing the profile in the CAS and reference it from the action result? Then it's just ~70 bytes of data.

Yeah, that makes more sense, though I would recommend gating it by a configuration option. What are your thoughts on including it in ExecuteResponse.server_logs? Or do you really need it to be part of ActionResult?

[osjo-meroton]

Gating it by a configuration option seems very sensible.

As for using the logs instead. We would need the profile to be easily accessible at runtime.

[moroten]

As for using the logs instead. We would need the profile to be easily accessible at runtime.

We meant remoteexecution.ExecutionResponse.server_logs, not to be confused with any logs of stdout/stderr on the servers.