Rewrite package for box2d v3+ - #3
Open
helmesjo wants to merge 6 commits into
Open
Conversation
Branch from packaging master. Drop the 2.4.1 C++ package layout and install the v3 C packaging tree from helmesjo/build2-box2d main. Source patches applied in follow-up commits.
Author
|
@Rookfighter Let me know if you have any objections against this. It's been a long time since the last update so if you don't have any opinion I'll just go ahead and complete it. :) |
Author
Add libenkits as a package dependency and resolve it from pkg.cppget.org testing. Link enkiTS into the unit suite, restore the upstream main.c symlink, drop the omit-DeterminismTest patch, and symlink test_determinism.c so the multithreaded determinism check is included again.
Symlink main.c from the upstream benchmark app and wire it like the
unit suite via shared helpers, liba{box2d}, and libenkits for the
task scheduler. Mark the executable test=false because a default full
run exceeds a unit-test time budget. Ignore generated timing CSV and
DAT files in the repository root .gitignore and under tests/benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI: All pass.
Why rewrite the build2 packaging for Box2D 3.x
Box2D v3was not an incremental release of thev2.4C++ API. It is a new C17 library with a different layout (include/box2d/+ flatsrc/), different public headers, and a different build (compiled C objects, own export macros, SIMD/validate options).The existing packaging targeted
v2.4.x(C++, split collision/common/dynamics/rope trees, separate libbox2d-tests / libbox2d-testbed with doctest/imgui-style deps). That structure does not map cleanly ontov3.x.A full replace on top of packaging master is appropriate so that:
v3.xlayout via submodule + symlinks.Version
3.1.1is a major jump relative to2.4.1, which matches the upstream break.Since both
Box2Dand the newBox3Dnow share layout, I rewrote this package to matchBox3Dbuild2package.NOTE:
Keeping the unit suite and benchmarks under
libbox2d/tests/for now matches thebox3dlayout and keeps white-box tests next tosrc/.Box2ddiffers frombox3dhere: it has no built-in scheduler, so tests/benches needenkiTS, whilebox3dcan use its in-tree one. That is a test-only dep, not part of the library API, and we can split packages later when we know upstreams intentions.