Repository navigation
pack lock: give back the lock on a failed write, trap before acquire, annotate a lost lock #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krassx
wants to merge
1
commit into
main
Choose a base branch
from
fix/pack-lock-review-followups
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Severity: P3 Low
Problem: Moving the trap before acquire does not close the window the comment describes. The leak window is between
mkdir "$lock"succeeding andprintf ... > "$lock/owner"completing, and the release in this trap cannot clean up in that window:PACK_LOCK_TOKENis assigned,pack_lock_releasereturns at its first line ([[ -n "$PACK_LOCK_TOKEN" ]] || return 0) and the lock stays.owneris written, release reads an empty owner. That is not equal to the token, so it takes the "held by another run" branch and leaves the directory.I checked the second case with
mkdir lk; PACK_LOCK_DIR=lk; PACK_LOCK_TOKEN=1.2; pack_lock_release; ls -d lk. It prints "held by another run now; left it alone" (and the new::warningannotation under Actions), andlkis still there.Impact: A SIGTERM or SIGINT (job cancel, timeout) in that sub-millisecond window still leaves an ownerless lock. Every later run then waits 300 s and fails with "stale lock?", which is the failure the first fix in this PR addresses. The new annotation would blame "another run" for it.
Scenario: The window is tiny, so this is rare. The point is that the PR text and this comment claim it is closed, and the new test only checks the textual order of
trapandpack_lock_acquirein the source. It never exercises the window.Fix: Either:
pack_lock_acquire, setPACK_LOCK_DIRandPACK_LOCK_TOKENbeforemkdir, and clear them ifmkdirfails; and inpack_lock_release, treat "owner empty and token set" as ours to remove only when we have just created the directory (for example, aPACK_LOCK_CREATED=1flag set right after a successfulmkdir); or