Repository navigation
Conversation
…#1592) Signed-off-by: Badre Tejado-Imam <btejado@redhat.com>
Update .ci/oci.Dockerfile to use Go 1.25 base image to support upcoming Go toolchain updates. This change updates the OpenShift CI base image from golang-1.24 to golang-1.25 and pins it by SHA256 digest for security. Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This reverts commit 14260a2. Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
* chore: update Go toolchain to 1.25.3 Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * chore: update Go toolchain to 1.25.5 Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fixup! chore: update Go toolchain to 1.25.5 Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fixup! fixup! chore: update Go toolchain to 1.25.5 Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fixup! fixup! fixup! chore: update Go toolchain to 1.25.5 Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fixup! fixup! fixup! fixup! chore: update Go toolchain to 1.25.5 Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> --------- Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Assisted-by: Claude Sonnet 4.6 Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> Co-authored-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Ales Raszka <araszka@redhat.com>
… update Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Backup - Unify annotation with default value
Signed-off-by: David Kwon <dakwon@redhat.com>
* feat: Mounting PVC into Workspace within Subpath Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Update doc Signed-off-by: Anatolii Bazko <abazko@redhat.com> * chore: Support multiple subpath mounts for a single PVC Signed-off-by: Anatolii Bazko <abazko@redhat.com> --------- Signed-off-by: Anatolii Bazko <abazko@redhat.com>
…ty (devfile#1603) Remove outdated section about workspace backup restore that was added during initial backup implementation. It is no longer relevant after changes in devfile#1572 Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Signed-off-by: dkwon17 <dakwon@redhat.com>
…th checks (devfile#1581) * Improve Che happy-path test reliability with retry logic and health checks This commit enhances the `.ci/oci-devworkspace-happy-path.sh` script to significantly improve test reliability in CI environments by adding: - Health checks for DWO and Che deployments using kubectl wait - Retry logic with exponential backoff (2 retries, 60s base delay) - Comprehensive artifact collection on failures - Graceful error handling and cleanup between retries - Clear error messages with stage identification The improvements address flakiness in the v14-che-happy-path Prow test by handling transient failures (image pull timeouts, API server issues, operator reconciliation delays) and providing detailed diagnostics for genuine failures. Key features: - DWO verification: Waits for deployment condition=available - Che verification: Waits for CheCluster condition=Available - Retry strategy: 2 attempts with exponential backoff + jitter - Artifact collection: Operator logs, CheCluster CR, pod info, events - Cleanup: Deletes failed deployments before retry - Realistic timeouts: 24 hours (86400s) for pod wait/ready Expected impact: Reduce CI flakiness from ~50% to >90% success rate for infrastructure-related failures, with significantly better diagnostics. Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com> Co-Authored-By: Oleksii Kurinnyi <okurinny@redhat.com> Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fixup! Improve Che happy-path test reliability with retry logic and health checks Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fixup! fixup! Improve Che happy-path test reliability with retry logic and health checks Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fixup! fixup! fixup! Improve Che happy-path test reliability with retry logic and health checks - Remove broken verifyCheDeployment() (CheCluster has no condition=Available) - Fix exit 1 -> return 1 in main() - Fix cleanup: use kubectl wait --for=delete instead of sleep 10 - Add retry for happy-path test (1 retry with 30s delay) - Add failure classification, reporting, and PR commenting - Fix pipe delimiter injection, variable quoting, artifact overwrite - Update README to match code changes Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fixup! fixup! fixup! fixup! Improve Che happy-path test reliability with retry logic and health checks Add CHE_REPO_BRANCH format validation to prevent injection Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> --------- Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
…le#1604) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.72.1 to 1.79.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.72.1...v1.79.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-version: 1.79.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…evfile#1601) Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.34.0 to 1.40.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.34.0...v1.40.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/sdk dependency-version: 1.40.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: David Kwon <dakwon@redhat.com>
…vfile#1600) Bumps [github.com/cloudflare/circl](https://github.com/cloudflare/circl) from 1.6.1 to 1.6.3. - [Release notes](https://github.com/cloudflare/circl/releases) - [Commits](cloudflare/circl@v1.6.1...v1.6.3) --- updated-dependencies: - dependency-name: github.com/cloudflare/circl dependency-version: 1.6.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…evfile#1608) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.16.5 to 5.17.1. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](go-git/go-git@v5.16.5...v5.17.1) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-version: 5.17.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…evfile#1612) Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.40.0 to 1.43.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.40.0...v1.43.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/sdk dependency-version: 1.43.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: David Kwon <dakwon@redhat.com> Assisted-by: Claude Code Opus 4.6
…le#1614) * fix: fall back to canonical backup auth secret name on restore When CopySecret writes an auth secret into the workspace namespace, it always uses DevWorkspaceBackupAuthSecretName ("devworkspace-backup-registry-auth") regardless of what name the admin configured (e.g. "quay-backup-auth"). GetNamespaceRegistryAuthSecret (the restore path) calls HandleRegistryAuthSecret with operatorConfigNamespace="" and looked only for the configured name, found nothing, and returned nil — leaving the workspace-restore init container without credentials and causing CrashLoopBackOff on private registries. Fix: when operatorConfigNamespace is empty and the configured name is not found, attempt a second Get using the canonical DevWorkspaceBackupAuthSecretName. Skip the extra lookup when the configured name already equals the canonical name to avoid a redundant API call. Propagate any non-NotFound error from the fallback. Assisted-by: Claude Sonnet 4.6 (1M context) Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fixup! fix: fall back to canonical backup auth secret name on restore fixup\! fix: fall back to canonical backup auth secret name on restore Address review feedback: - Use canonical DevWorkspaceBackupAuthSecretName for workspace NS lookup directly instead of falling back (dkwon17) - Remove unused secretGR variable and schema import (rohanKanojia) Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fixup! fixup! fix: fall back to canonical backup auth secret name on restore fixup\! fixup\! fix: fall back to canonical backup auth secret name on restore Use canonical name only on restore path, keep configured name on backup path Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * fixup! fixup! fixup! fix: fall back to canonical backup auth secret name on restore fixup\! fixup\! fixup\! fix: fall back to canonical backup auth secret name on restore Replace "canonical" with "predefined" throughout Assisted-by: Claude Opus 4.6 (1M context) Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> --------- Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Update Go toolchain to 1.25.9 and use Red Hat UBI9 go-toolset:1.25-1777043046 with digest sha256:35f08031de19eb51d6b35ed62c6357d3529bc69a8db65cf623ea5f0b44051999 Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…1533) * chore: creating automount objects should not trigger workspace to restart
* chore (deps) : update controller-runtime to v0.23.1
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
* chore (deploy) : Update manifests to reflect controller-runtime upgrade to v0.23.1
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
* refactor : adjust WebhookManagedBy as per controller-runtime upgrade
This method arguments were changed in controller-runtime v0.23.0.
Existing code of the form builder.WebhookManagedBy(mgr).For(&corev1.Deployment{}) has to be changed to builder.WebhookManagedBy(mgr, &appsv1.Deployment{})
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
---------
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…evfile#1619) Signed-off-by: Anatolii Bazko <abazko@redhat.com>
…evfile#1616) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.17.1 to 5.18.0. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](go-git/go-git@v5.17.1...v5.18.0) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-version: 5.18.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…evfile#1621) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.18.0 to 5.19.0. - [Release notes](https://github.com/go-git/go-git/releases) - [Changelog](https://github.com/go-git/go-git/blob/main/HISTORY.md) - [Commits](go-git/go-git@v5.18.0...v5.19.0) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-version: 5.19.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Signed-off-by: David Kwon <dakwon@redhat.com>
Signed-off-by: David Kwon <dakwon@redhat.com>
…mplate.metadata field (devfile#1711) Signed-off-by: David Kwon <dakwon@redhat.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…evfile#1709) Bumps [go.opentelemetry.io/otel/exporters/otlp/otlptrace](https://github.com/open-telemetry/opentelemetry-go) from 1.40.0 to 1.45.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.40.0...v1.45.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlptrace dependency-version: 1.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Honor cluster TLS profile only when tlsAdherence policy requires it * Set up TLS profile watcher even when adherence policy is legacy * Use library-go defaults as fallback * Run RegisterSecurityProfileWatcher only on OpenShift platform Assisted-by: Claude Opus 4.6 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: David Kwon <dakwon@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
…tlptracegrpc (devfile#1707) Bumps [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc](https://github.com/open-telemetry/opentelemetry-go) from 1.40.0 to 1.45.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.40.0...v1.45.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc dependency-version: 1.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Add release notes for v1.0.0 covering NetworkPolicy provisioning, OpenShift TLS configuration, deployment label tolerance, and backup/restore fix for multi-node clusters. Signed-off-by: Badre Tejado-Imam <btejado@redhat.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: David Kwon <dakwon@redhat.com> Co-authored-by: David Kwon <dakwon@redhat.com>
Copy OLM catalog bundle and channel entries from the 1.0.x release branch back to main. Signed-off-by: Badre Tejado-Imam <btejado@redhat.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
* chore(deps): update controller-runtime to v0.25.2 * ci: upgrade Codecov action to v7.1.1 Assisted-by: Codex Signed-off-by: Rohan Kumar <rohaan@redhat.com>
devfile#1718) Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Move the infrastructure initialization check and operator namespace lookup out of GetDefaultNetworkPolicy and into setDefaultNetworkPolicy, passing the namespace in as an argument instead. This lets external consumers (such as che-operator) reuse the default network policy rules with an explicit namespace, without depending on the infrastructure package being initialized in their process. Assisted-by: Claude Opus 5 Signed-off-by: Anatolii Bazko <abazko@redhat.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
…torage provisioners (devfile#1698) Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
…1692) Set default init container imagePullPolicy to IfNotPresent for project-clone, restore containers, and DWOC-defined (.config.workspace.initContainers) init containers. Signed-off-by: David Kwon <dakwon@redhat.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
…Config (devfile#1721) * fix: do not mutate defaultConfig in GetDefaultNetworkPolicy Remove the assignment to defaultConfig.Workspace.NetworkPolicy from GetDefaultNetworkPolicy. GetDefaultNetworkPolicy is a public helper intended to return the default ingress/egress rules for network policies, and modifying the package-level defaultConfig was an unintended side effect. The default network policy configuration on defaultConfig is already initialized by setDefaultNetworkPolicy. Signed-off-by: Anatolii Bazko <abazko@redhat.com> * fix: preserve empty ingress/egress lists in NetworkPolicyConfig Drop `omitempty` from the Ingress and Egress JSON tags of NetworkPolicyConfig. An empty list has a distinct meaning for these fields: it denies all ingress/egress traffic, while an unset field falls back to the default rules. With `omitempty`, an empty list was dropped during serialization, so a deny-all configuration silently turned into the default allow rules. Add a test that resolves an external DevWorkspaceOperatorConfig with empty ingress and egress lists and verifies they stay empty. Assisted-by: Claude Code Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Anatolii Bazko <abazko@redhat.com> * fix: return copies of default rules from GetDefaultNetworkPolicy GetDefaultNetworkPolicy returned the package-level default rule slices directly. On OpenShift the appended slice had a fresh backing array, but its elements still shared LabelSelector pointers and MatchLabels maps with the defaults. A caller extending the returned rules (the function is public for operators such as che-operator) could therefore corrupt the operator's defaults for the rest of the process lifetime. Deep-copy the default ingress and egress rules before returning them. Tighten the tests: assert literal expected rules on Kubernetes instead of comparing against the returned global, check that the OpenShift rule targets the given operator namespace, and verify that mutating the returned rules leaves the defaults unchanged. Assisted-by: Claude Code Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Anatolii Bazko <abazko@redhat.com> * remove defaults_test.go Signed-off-by: Anatolii Bazko <abazko@redhat.com> --------- Signed-off-by: Anatolii Bazko <abazko@redhat.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* chore: add graphify knowledge graph and team setup - Add graphify-out/graph.json and GRAPH_REPORT.md for team-shared codebase navigation - Exclude machine-local graphify files in .gitignore - Add Codebase Navigation section to AGENTS.md with slash command usage - Add graphify onboarding steps to CONTRIBUTING.md Assisted-by: Claude Sonnet 4.6 (1M context) Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * chore: add graphify IDE integration for Claude Code and Cursor - .claude/settings.json: project-wide hooks enforcing graphify-first navigation - .cursor/rules/graphify.mdc: Cursor IDE graphify integration Assisted-by: Claude Sonnet 4.6 (1M context) Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * chore: update graphify knowledge graph and exclude dated backups Assisted-by: Claude Sonnet 4.6 (1M context) Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * chore: add graphify OpenCode integration Assisted-by: Claude Sonnet 4.6 (1M context) Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * chore: regenerate Graphify graph from clean checkout Rebuild the shared graph from the PR rebased onto origin/main and generate readable community labels for the report. Assisted-by: Codex Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> * docs: clarify Graphify setup Document CLI installation before the first Graphify setup command. Add missing trailing newlines to the Claude and OpenCode JSON configuration without changing their contents. Assisted-by: Codex Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> --------- Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com> Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…Terminal (devfile#1724) Add the openshift-console namespace (selected via the network.openshift.io/policy-group=console label) to the default NetworkPolicy ingress peers so that the OpenShift console can reach WebTerminal workspaces. Assisted-by: Claude Code Signed-off-by: Anatolii Bazko <abazko@redhat.com> Co-authored-by: Claude Code <noreply@anthropic.com>
Signed-off-by: Badre Tejado-Imam <btejado@redhat.com>
…t and watches Signed-off-by: Badre Tejado-Imam <btejado@redhat.com>
…s stalls Signed-off-by: Badre Tejado-Imam <btejado@redhat.com>
- Remove unused GatewayClassName field from GatewayReference struct - Add MinLength/MaxLength validation markers on GatewayReference fields - Gate HTTPRoute watch and cache behind Gateway API CRD availability using infrastructure detection pattern (IsGatewayAPIInstalled) - Scope httproutes RBAC from wildcard to explicit verbs - Make endpoint readiness log/status messages generic - Extract httpRouteRequestTimeout constant for HTTPRoute timeout - Reuse getURLForEndpoint for HTTPRoute URL construction Assisted-by: Claude Opus 4.6 Signed-off-by: Badre Tejado-Imam <btejado@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Badre Tejado-Imam <btejado@redhat.com>
btjd
force-pushed
the
23675-gateway-api
branch
from
October 27, 2026 14:25
d401070 to
7e82f43
Compare
| fi | ||
|
|
||
| # Download and run the remote test script | ||
| if ! bash <(curl -s "https://raw.githubusercontent.com/eclipse/che/${CHE_REPO_BRANCH}/tests/devworkspace-happy-path/remote-launch.sh"); then |
| healthCheckHttpClientTransport.Proxy = proxyFunc | ||
| } | ||
| healthCheckHttpClientTransport.TLSClientConfig = &tls.Config{ | ||
| InsecureSkipVerify: true, |
btjd
force-pushed
the
23675-gateway-api
branch
from
October 27, 2026 17:08
7e82f43 to
fd74efa
Compare
- Call syncHTTPRoutes unconditionally so stale HTTPRoutes get cleaned up when desired list becomes empty - Stop ignoring ParentReference.Namespace in diff opts so gateway namespace changes propagate to existing HTTPRoutes - Check IsGatewayAPIInstalled() before returning Gateway API solver for clear upfront error when CRDs are not installed - Fix annotation ordering in solver: user annotations first, controller annotation last, matching basic solver pattern - Add GatewayRef details to GetCurrentConfigString output - Replace deprecated gwapiv1.AddToScheme with gwapiv1.Install - Remove redundant RequeueAfter on endpoints-not-ready path since watch-based triggers handle reconciliation - Remove logging on NotInSyncError to match other sync files - Remove Eclipse Che reference from GatewayRef doc comment - Add RFC 1123 pattern validation on GatewayReference Name and Namespace - Test improvements: use routing class constant, add ExposedEndpoints and hostname assertions, add nil-pointer guards, make deleteHTTPRoute idempotent, add gateway-api failure test cases Assisted-by: Claude Code Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Badre Tejado-Imam <btejado@redhat.com>
btjd
force-pushed
the
23675-gateway-api
branch
from
October 27, 2026 18:53
fd74efa to
cfd3b2f
Compare
The DevWorkspaceRouting reconciler synced HTTPRoutes unconditionally, so
on clusters without the Gateway API CRDs (e.g. default OpenShift) listing
HTTPRoutes failed with a no-match error. That error blocked every
workspace - including cluster-tls/web-terminal routings that never use
Gateway API - on the "Preparing HTTPRoutes" step until it timed out.
Gate the HTTPRoute sync on infrastructure.IsGatewayAPIInstalled(),
mirroring the Owns(&gwapiv1.HTTPRoute{}) watch registration in
SetupWithManager. When the CRD is absent no HTTPRoutes can exist or be
desired, so the sync is safely skipped.
This is not reproducible in envtest because the suite always registers
the HTTPRoute CRD; it is covered by the OpenShift e2e suite.
Assisted-by: Claude Code
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Badre Tejado-Imam <btejado@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces support for the Kubernetes Gateway API by implementing a new
gateway-apirouting class. To ensure strict separation of concerns and avoid breaking backward compatibility for existing Ingress/Route users, this feature is implemented via a dedicated solver.Key implementations:
RoutingConfiginDevWorkspaceOperatorConfigto accept aGatewayRef(Name, Namespace, and GatewayClassName), allowing cluster admins to define the parent Gateway for workspace routes.gateway-apirouting class constant.GatewayAPISolver): GeneratesHTTPRouteresources for public Devfile endpoints. It explicitly links to the admin-definedGatewayviaParentRefs, routes HTTPS traffic to the workspaceService(with a 10-hour timeout), and uses a nativeHTTPRequestRedirectFilterto force HTTP (port 80) to HTTPS (port 443) redirects.sync_httproutes.goto handle the creation, updating, and garbage collection ofHTTPRouteswithin the cluster.ClusterRolepermissions for the operator to managehttproutesin thegateway.networking.k8s.ioAPI group.What issues does this PR fix or reference?
Fixes #23675
Is it tested? How?
Yes.
devworkspacerouting_controller_test.go. Theenvtestenvironment was updated to load the upstreamgateway.networking.k8s.io_httproutes.yamlCRD. The tests verify successful DWR phase transitions,HTTPRoutegeneration, correctParentRefsbinding,BackendRefport mapping, and endpoint URL resolution.Gatewayresource, and verifying that the DevWorkspace Operator correctly generates and binds theHTTPRoutesupon workspace startup.PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che