Fix Windows portability of settings.xml hash in multiple-distributions test (#945 follow-up)#7
Merged
Conversation
Use a cross-platform SHA-256 helper for settings.xml snapshots so the stacked-distributions workflow works under Windows git-bash, where shasum is not available. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #6, which merged just before its Windows CI finished. The
stacked-distributionsjob failed onwindows-latest:shasumisn't on PATH in git-bash on Windows runners, so the byte-for-bytesettings.xmlcomparison couldn't run. The buggy lines are currently live onmain(multiple-distributions.yml:106and:166), so the Windows leg fails onmaintoo.Fix
Replace the direct
shasum -a 256calls with a small portable SHA-256 helper that works on Ubuntu, macOS and Windows git-bash, tryingsha256sum→shasum -a 256→openssl dgst -sha256in order. The assertion is unchanged —settings.xmlis still verified byte-for-byte unchanged by the secondsetup-javastep; only the hashing mechanism is made cross-platform. No assertions were weakened or skipped.Classification: pr-caused (Windows/git-bash portability bug introduced by #6).
Validation
actionlint+ shellcheck clean.workflow_dispatchrun on this branch passed on all three OSes, includingwindows-latest.