feat(v8): port missing monorepo parity commits (test-plan, grpc-size, exit-signal, log-redaction)#58
Open
AakashHotchandani wants to merge 2 commits into
Open
feat(v8): port missing monorepo parity commits (test-plan, grpc-size, exit-signal, log-redaction)#58AakashHotchandani wants to merge 2 commits into
AakashHotchandani wants to merge 2 commits into
Conversation
…exit-signal/log-redaction Ports 4 upstream webdriverio/webdriverio v8 commits to the standalone v8 line: - #15231 test management (testPlanId) support + CLI-only caps stripping + build-start errors - #15217 raise gRPC send/receive message size limit to 20 MB - #15146 terminate CLI process with SIGINT (not SIGKILL) on Unix - #15200 redact credentials from CLI log output Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
AakashHotchandani
requested review from
07souravkunda and
pranay-v29
and removed request for
a team
July 17, 2026 08:46
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v8 extraction dropped several
wdio-browserstack-servicecommits that exist in the monorepo v8 line (and in this repo'smain/v9). This ports the 4 missing ones so the standalone v8 is at parity before the8.49.0release.Found via a per-commit audit of monorepo-v8
wdio-browserstack-servicevs standalone v8 (verified by reading each diff, not marker-greps).Ported (each matches the upstream diff)
867819cdb)constants.ts,types.ts,util.ts,cli/cliUtils.ts,cli/index.ts,launcher.ts,service.tscdbd52ebd)cli/grpcClient.ts13e4c92c6)exitHandler.tsbbb4cb495)cli/cliLogger.tsWhy this matters
The regression suite's
test_test_plan_id_log(6 cells) was failing because the v8 service had no test-plan code — it never emitted"Test Plan Id sent in request:"intobstack-wdio-service.log. #15231 restoresgetTestPlanId()+ that log line, which fixes those failures.Already present (audited, no port needed)
#15330 (screenshot), #15134 (isCLIEnabled), #15036 (instrumentation), #14989 (pid — end-state already true), #14920 (multiRemote + session name/status).
Verification
util.ts).npm ci+npm run build(buf generate && tsc -p tsconfig.prod.json) → exit 0, no TS errors.@wdio/browserstack-servicepatch.🤖 Generated with Claude Code