Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/browserbase/_response.py
Original file line number Diff line number Diff line change
Expand Up @@ -629,12 +629,12 @@ class AsyncResponseContextManager(Generic[_AsyncAPIResponseT]):
when the context manager exits
"""

def __init__(self, api_request: Awaitable[_AsyncAPIResponseT]) -> None:
self._api_request = api_request
def __init__(self, request_func: Callable[[], Awaitable[_AsyncAPIResponseT]]) -> None:
self._request_func = request_func
self.__response: _AsyncAPIResponseT | None = None

async def __aenter__(self) -> _AsyncAPIResponseT:
self.__response = await self._api_request
self.__response = await self._request_func()
return self.__response

async def __aexit__(
Expand Down Expand Up @@ -680,9 +680,9 @@ def wrapped(*args: P.args, **kwargs: P.kwargs) -> AsyncResponseContextManager[As

kwargs["extra_headers"] = extra_headers

make_request = func(*args, **kwargs)
make_request = functools.partial(func, *args, **kwargs)

return AsyncResponseContextManager(cast(Awaitable[AsyncAPIResponse[R]], make_request))
return AsyncResponseContextManager(cast(Callable[[], Awaitable[AsyncAPIResponse[R]]], make_request))

return wrapped

Expand Down Expand Up @@ -730,9 +730,9 @@ def wrapped(*args: P.args, **kwargs: P.kwargs) -> AsyncResponseContextManager[_A

kwargs["extra_headers"] = extra_headers

make_request = func(*args, **kwargs)
make_request = functools.partial(func, *args, **kwargs)

return AsyncResponseContextManager(cast(Awaitable[_AsyncAPIResponseT], make_request))
return AsyncResponseContextManager(cast(Callable[[], Awaitable[_AsyncAPIResponseT]], make_request))

return wrapped

Expand Down
11 changes: 11 additions & 0 deletions tests/test_response.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import gc
import json
import warnings
from typing import Any, List, Union, cast
from typing_extensions import Annotated

Expand Down Expand Up @@ -275,3 +277,12 @@ async def test_async_response_parse_expect_model_union_non_json_content(async_cl
obj = await response.parse(to=cast(Any, Union[CustomModel, OtherModel]))
assert isinstance(obj, str)
assert obj == "foo"


async def test_async_streamed_response_not_entered(async_client: AsyncBrowserbase) -> None:
with warnings.catch_warnings(record=True) as caught:
warnings.simplefilter("always")
async_client.sessions.with_streaming_response.create()
gc.collect()

assert [str(w.message) for w in caught] == []
Loading