fix(opencode): retry nested OpenAI errors - #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
No linked issue.
Type of change
What does this PR do?
OpenAI Responses streams can report a transient failure as a nested response.failed event with the error at response.error. The existing parser only recognized top-level error events, so nested server_error and server_is_overloaded events became terminal unknown errors.
This keeps the parser change narrow: those two nested transient codes become retryable APIError values and flow through the existing SessionRetry policy. Other nested response.failed codes retain their current terminal behavior.
Follow-up risk intentionally left out of scope: SessionRetry caps each backoff wait, but generic retryable API errors do not currently have a total-attempt cap.
How did you verify your code works?
Added regression coverage for both nested transient codes and for a nested non-retryable code remaining terminal.
Screenshots / recordings
Not applicable; no UI change.
Checklist
Summary by cubic
Makes nested OpenAI stream server errors retryable so transient failures don’t abort sessions. Detects
server_errorandserver_is_overloadedinsideresponse.failedevents and routes them through the existing retry policy.opencodeparser to handle nestedresponse.failederrors:server_errorandserver_is_overloadednow map to retryable API errors; other nested codes stay terminal.Written for commit 05f9985. Summary will update on new commits.