ztest to confirm default terminal output formats - #7298
Open
philrz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #7289, writing a ztest to confirm the default output formats on a terminal is challenging. But since we regressed in this area in both #7287 and #7075, I asked Claude to come up with a minimally hacky way to cover this, and I've simplified it to what's here. It's not the prettiest since I needed to adapt to some differences in the
scripttool between macOS and Linux and then use regexp to deal with the extra characters that show up in the raw output capture, but I did confirm that the test fails at the commits right before #7287 and #7075.