fix: throw on invalid Date serialization instead of producing NaN string (#3318) - #3722
Closed
marceli1404 wants to merge 1 commit into
Closed
fix: throw on invalid Date serialization instead of producing NaN string (#3318)#3722marceli1404 wants to merge 1 commit into
marceli1404 wants to merge 1 commit into
Conversation
new Date(undefined) (an invalid Date) was serialized as '0NaN-NaN-NaNTNaN:NaN:NaN.NaN+NaN:NaN' which is meaningless and harmful for Postgres queries. Now throws a clear error. Closes brianc#3318
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
new Date(undefined)(an invalid Date) was serialized as"0NaN-NaN-NaNTNaN:NaN:NaN.NaN+NaN:NaN"which is meaningless and harmful for Postgres queries.Changes
isNaN(val.getTime())check inprepareValue()inpackages/pg/lib/utils.jswhen handling Date objectsError('Invalid Date value provided to query parameter')when an invalid date is detectednew Date(undefined),new Date(NaN),new Date('not a date')Valid dates continue to work as before.
Closes #3318