You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[P2] Support WebSocket v5 negotiation in the async exec client #14
The upstream report describes HTTP 400 during exec WebSocket upgrades when the client defaults to v4.channel.k8s.io. The sync implementation now advertises v5 and v4, while the async implementation observed during triage still defaults to v4.
Verify the remaining async compatibility gap. Implement negotiation and the required protocol behavior together rather than changing the advertised protocol alone. Preserve compatibility with servers supporting only v4 and with explicitly configured subprotocol headers.
Acceptance criteria:
Test v5 negotiation and its channel-close semantics.
Test v4 compatibility and explicit subprotocol configuration.
Confirm sync behavior is not regressed and document any remaining protocol limitations.
Clarification to the original assignment: this task's designated agent/base branch is agent/p2-issue-14. Raise/target the PR against that branch, not master; the existing draft PR has been retargeted accordingly. Keep the requested commit order: first a test-only commit demonstrating the issue, then a separate fix commit only if reproduced. If it does not reproduce, leave the evidence/test commit and explain why no fix is appropriate.
Activity
brendandburns commentedon Nov 19, 2026
Clarification to the original assignment: this task's designated agent/base branch is
agent/p2-issue-14. Raise/target the PR against that branch, notmaster; the existing draft PR has been retargeted accordingly. Keep the requested commit order: first a test-only commit demonstrating the issue, then a separate fix commit only if reproduced. If it does not reproduce, leave the evidence/test commit and explain why no fix is appropriate.