Skip to content

chore: add some tests for ::part() and ::highlight() - #34

Merged
bramus merged 2 commits into
bramus:mainfrom
projectwallace:feat/highlight-universal
Oct 5, 2026
Merged

bramus merged 2 commits into
bramus:mainfrom
projectwallace:feat/highlight-universal

Conversation

@bartveneman

Copy link
Copy Markdown
Contributor

Just saw w3c/csswg-drafts#14301 passing by and wondered if we had any tests for PseudoElement selectors with arguments, so I added some. I'm actually not sure if they're all supposed to be 0,0,1, so please check my work.

@bramus

bramus commented Oct 5, 2026

Copy link
Copy Markdown
Owner

::highlight without any arguments (or with the * as its argument) should be 0,0,0. The rest looks fine.

@bartveneman

Copy link
Copy Markdown
Contributor Author

Updated implementation. One note: it looks really similar to the calculation of ::view-transition-* pseudo elements, but not exactly, so I've just added a new case block instead of trying to shoe-horn it in the existing code.

@bramus
bramus self-requested a review October 5, 2026 19:29
@bramus
bramus merged commit 5db0da5 into bramus:main Oct 5, 2026
3 checks passed
@bartveneman
bartveneman deleted the feat/highlight-universal branch October 6, 2026 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants