Update google provider types#307
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3a0ec8523
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".
| | GoogleFinishReason::ImageRecitation | ||
| | GoogleFinishReason::ImageProhibitedContent | ||
| | GoogleFinishReason::Language |
There was a problem hiding this comment.
For a Google response whose candidate.finishReason is IMAGE_RECITATION, IMAGE_PROHIBITED_CONTENT, or LANGUAGE, this collapses the typed provider value to ContentFilter. When that UniversalResponse is serialized back to Google, response_from_universal calls to_provider_string(ProviderFormat::Google), which emits SAFETY for every ContentFilter, so a Google→universal→Google round trip no longer preserves these exact provider finish reasons; before this change they fell through as Other(...) and round-tripped as the original string. If exact provider response metadata matters, keep these as Other or carry the original value separately.
Useful? React with 👍 / 👎.
1 participant
Automated update of Lingua provider types.
Provider:
googleFeedback: comment
/bt goodor/bt badto log review feedback to the Braintrust trace.Validation
./pipelines/generate-provider-types.sh google: successmake generate-types: successmake generate-types: successcargo fmt --all: successcargo build --all-features: successcargo clippy --all-targets --all-features -- -D warnings: successmake typed-boundary-check: successcargo test -p coverage-report --test cross_provider_test cross_provider_transformations_have_no_unexpected_failures: successThis PR is created even when validation fails so the generated update and repair attempt are available for manual follow-up.