Skip to content

Fix gem build pkg dir #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
David Elner (delner) merged 2 commits into from
Jun 16, 2026
+7 −2
Merged

Fix gem build pkg dir #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
621d354
Fixed: Broken pkg/ directory for releases
Jun 15, 2026
476b5ac
Changed: Bump rubygems/release-gem action
Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ jobs:
bundler-cache: true

- name: Publish package with attestation
uses: rubygems/release-gem@6317d8d1f7e28c24d28f6eff169ea854948bd9f7 # v1.2.0
uses: rubygems/release-gem@052cc82692552de3ef2b81fd670e41d13cba8092 # v1.4.0
with:
await-release: ${{ inputs.dry_run && 'false' || 'true' }}
setup-trusted-publisher: ${{ inputs.dry_run && 'false' || 'true' }}
Expand Down
7 changes: 6 additions & 1 deletion Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,12 @@ end

desc "Build the gem"
task build: [:clean] do
# Output to pkg/ (Bundler convention). rubygems/release-gem awaits pkg/*.gem
# after pushing, so the gem must land there — not the repo root.
require_relative "lib/braintrust/version"
sh "gem build braintrust.gemspec"
mkdir_p "pkg"
mv "braintrust-#{Braintrust::VERSION}.gem", "pkg/"
end

desc "Generate YARD documentation"
Expand Down Expand Up @@ -200,7 +205,7 @@ end
# Release tasks
namespace :release do
task publish: [:lint, :build] do
gem_files = FileList["braintrust-*.gem"]
gem_files = FileList["pkg/braintrust-*.gem"]
if gem_files.empty?
puts "Error: No gem file found. Build task should have created it."
exit 1
Expand Down