pass baseExperimentId to summarize#2124
Open
Barrett Pyke (barrettpyke) wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Eval stores baseExperimentId correctly on the experiment but the final summary does not pass it as the explicit comparison ID. As a result, summary comparison can fall back to project/default baseline resolution and show wrong diffs.
Reproduction
Expected
comparison-${timestamp}experiment should be compared tobaseline-${timestamp}experimentObserved
comparison-${timestamp}is compared to the default baseline experiment selected in Step 2Fix
baseExperimentIdin summarize call. Ifundefinedfallback to Experiment's persistedbase_exp_idwhich may have been resolved during experiment init frombaseExperimentName,BaseExperiment(...)data, or backend baseline resolution.experiment.summarize()receives an explicitcomparisonExperimentIdfetchv1/experiment/${comparisonExperimentId}to resolve the comparison experiment name for display.Testing
baseExperimentIdandbaseExperimentNamerunEvaluatorforwardsbaseExperimentIdto summaryrunEvaluatorforwards persistedbaseExperimentNameid to summaryexperiment.summarizeresolves explicit comparison experiment name