Improved recipe viewer slots and general compat - #78
Open
Trinsdar wants to merge 85 commits into
Open
Conversation
screret
requested changes
Jul 30, 2026
… REI is happier with our tooltips
screret
reviewed
Aug 1, 2026
screret
left a comment
screret
left a comment
Collaborator
There was a problem hiding this comment.
went and touched this up a 'bit', could you test the stuff now and make sure it works? Thanks!
…into the parent class
…create a dummy recipe viewer slot widget impl
…st of the actual JEI slot's values with new ones. this is done because JEI keeps track of all recipe slots & it's easier to replace existing slots' data than it is to replace the slots themselves.
…s in ModularUIRecipeCategory and ModularUIREIDisplayCategory to `getMaxWidth` and `getMax(Display)Height` respectively
…dd variants for JEI and REI too (so it isn't just EMI)
…itialized. why is that? no clue. Oh well.
Trinsdar
changed the title
because MUI initializes the screen/panel sizing after JEI wants to use them
…ries` list is empty OOps.
…r toggling the debug overlay when hovering recipe preview embeds
…e instead of keeping a global cache Java garbage collection will take care of the rest, right?
…'d always just redraw existing elements from the screen we're embedded in
(i cant test this, sorry. laptop running out of battery.)
This reverts commit 79b44d5. Reverted since the previous method of adding the tooltips made it possible to modify said tooltips from the widget
…ved" This reverts commit 82cd7fc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.