feat(elements): Enable Blueprint animations#4718
Open
jfox-box wants to merge 4 commits into
Open
Conversation
jfox-box
changed the title
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds a reusable ChangesBlueprint animations
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Storybook
participant AnimationDecorator
participant BlueprintProvider
participant Story
Storybook->>AnimationDecorator: render story
AnimationDecorator->>BlueprintProvider: set animation phases enabled
BlueprintProvider->>Story: render wrapped story
Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.storybook/preview.tsx:
- Around line 33-47: Update withBlueprintAnimations in .storybook/preview.tsx so
Chromatic explicitly disables both animationsPhase1Enabled and
animationsPhase2Enabled for all wrapped components, including their nested
BlueprintProvider instances; retain the existing enabled configuration for
non-Chromatic runs.
In `@src/elements/common/withBlueprintAnimations.tsx`:
- Around line 15-26: Update the WithBlueprintAnimations wrapper to destructure
enableBlueprintAnimations before rendering Component, forwarding only the
remaining props so the HOC-only control prop cannot reach wrapped DOM elements.
Add a regression test using a DOM-facing child that verifies the control prop is
not rendered as an attribute.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c2c55441-2ad1-43c4-b541-7dc19de20c7f
📒 Files selected for processing (11)
.storybook/preview.tsxsrc/elements/common/__tests__/withBlueprintAnimations.test.tsxsrc/elements/common/withBlueprintAnimations.tsxsrc/elements/content-explorer/ContentExplorer.tsxsrc/elements/content-picker/ContentPicker.jssrc/elements/content-preview/ContentPreview.jssrc/elements/content-sharing/ContentSharing.jssrc/elements/content-sharing/ContentSharingV2.tsxsrc/elements/content-sidebar/ContentSidebar.jssrc/elements/content-uploader/ContentUploader.tsxsrc/features/presence/PresenceAvatarList.tsx
jfox-box
changed the title
jfox-box
force-pushed
the
add-blueprint-animations
branch
2 times, most recently
from
July 23, 2026 03:26
f5221ff to
ee33922
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/elements/common/withBlueprintAnimations.tsx`:
- Around line 9-16: Rename the exported control prop in BlueprintAnimationsProps
and its resolution in withBlueprintAnimations to enableBlueprintAnimations,
preserving the existing boolean and per-phase behavior. Update
src/elements/common/withBlueprintAnimations.tsx lines 9-16 and the resolver at
line 53; replace animationsEnabled inputs in
src/elements/common/__tests__/withBlueprintAnimations.test.tsx lines 50-105 and
verify enableBlueprintAnimations is not forwarded to the rendered element.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d33b4ab9-8aa0-4c19-a746-3baf8b1b850b
⛔ Files ignored due to path filters (1)
src/features/presence/__tests__/__snapshots__/Presence.test.js.snapis excluded by!**/*.snap
📒 Files selected for processing (11)
.storybook/preview.tsxsrc/elements/common/__tests__/withBlueprintAnimations.test.tsxsrc/elements/common/withBlueprintAnimations.tsxsrc/elements/content-explorer/ContentExplorer.tsxsrc/elements/content-picker/ContentPicker.jssrc/elements/content-preview/ContentPreview.jssrc/elements/content-sharing/ContentSharing.jssrc/elements/content-sharing/ContentSharingV2.tsxsrc/elements/content-sidebar/ContentSidebar.jssrc/elements/content-uploader/ContentUploader.tsxsrc/features/presence/PresenceAvatarList.tsx
🚧 Files skipped from review as they are similar to previous changes (8)
- src/elements/content-picker/ContentPicker.js
- src/elements/content-sidebar/ContentSidebar.js
- src/elements/content-sharing/ContentSharingV2.tsx
- src/elements/content-uploader/ContentUploader.tsx
- src/elements/content-preview/ContentPreview.js
- src/elements/content-explorer/ContentExplorer.tsx
- .storybook/preview.tsx
- src/elements/content-sharing/ContentSharing.js
jfox-box
force-pushed
the
add-blueprint-animations
branch
from
July 23, 2026 04:05
ee33922 to
0bce84c
Compare
tjuanitas
reviewed
Jul 23, 2026
Animations will be turned on by default in all elements. Opt out with `animationsEnabled={false}`.
jfox-box
force-pushed
the
add-blueprint-animations
branch
from
July 23, 2026 20:45
0bce84c to
4ff5fa3
Compare
tjuanitas
reviewed
Jul 23, 2026
| } | ||
|
|
||
| export default withBlueprintModernization(ContentSharing); | ||
| export default withBlueprintAnimations(withBlueprintModernization(ContentSharing)); |
Contributor
There was a problem hiding this comment.
I don't think V2 AND V1 both need the providers right? V1 doesn't have any blueprint components in it. it's just calling v2
Contributor
Author
There was a problem hiding this comment.
Removed the wrapper from V1 and put it around V2 instead.
tjuanitas
reviewed
Jul 23, 2026
Comment on lines
+22
to
+23
| await waitFor(() => { | ||
| expect(screen.getByRole('heading', { name: 'Share ‘Box Development Guide.pdf’' })).toBeVisible(); |
Contributor
There was a problem hiding this comment.
are you able to just await the expect? or does it actually need the waitFor?
Suggested change
| await waitFor(() => { | |
| expect(screen.getByRole('heading', { name: 'Share ‘Box Development Guide.pdf’' })).toBeVisible(); | |
| await expect(screen.getByRole('heading', { name: 'Share ‘Box Development Guide.pdf’' }).toBeVisible(); |
Contributor
Author
There was a problem hiding this comment.
Unfortunately await expect won't work because it will find the element but the opacity won't be high enough to count as visible. waitFor will keep retrying until it becomes visible
tjuanitas
reviewed
Jul 23, 2026
| * - `false`: all phases off | ||
| * - object: per-phase overrides (omitted keys default on) | ||
| */ | ||
| animationsEnabled?: boolean | BlueprintAnimationPhases; |
Contributor
There was a problem hiding this comment.
consumers pass this prop in from the root element right?
such as:
<ContentPreview ... animationsEnabled={...} />
if that's the case, I think coderabbits suggestion is better. something like enableBlueprintAnimations:
- it matches the modernization prop
- it specifies that this is specifically for blueprint
tjuanitas
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables Blueprint animations in Elements (Explorer, Picker, Preview, Sidebar, Uploader, Sharing, Presence)
animationsEnabled={false}.animationsEnabled={{ animationsPhase1Enabled: true }}Followup: animations phase 3 is in progress in Blueprint, we should add when they ship it.
Summary by CodeRabbit
New Features
Tests