Skip to content

feat: lay out Theme and UI density side by side in settings dialog #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phatpham9 merged 1 commit into from
Jun 23, 2026
Merged

feat: lay out Theme and UI density side by side in settings dialog #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions core/render.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,11 +235,12 @@ export function renderIndexPage(data: PageData): string {
</button>
</div>
<p class="config-dialog-copy">Adjust the reader appearance and choose which sources appear in the feed.</p>
<div class="config-section-row">
<section class="config-section" aria-labelledby="config-theme-title">
<div class="config-section-header">
<h3 id="config-theme-title" class="config-section-title">Theme</h3>
</div>
<div class="config-options config-options--two-column config-options--choice-grid">
<div class="config-options config-options--choice-grid">
<label class="config-option config-option--choice">
<input type="radio" name="ui-theme" value="dark" data-theme-option checked />
<span class="config-option-body config-option-body--choice">
Expand Down Expand Up @@ -269,7 +270,7 @@ export function renderIndexPage(data: PageData): string {
<div class="config-section-header">
<h3 id="config-density-title" class="config-section-title">UI density</h3>
</div>
<div class="config-options config-options--two-column config-options--choice-grid">
<div class="config-options config-options--choice-grid">
<label class="config-option config-option--choice">
<input type="radio" name="ui-density" value="current" data-density-option checked />
<span class="config-option-body config-option-body--choice">
Expand All @@ -296,6 +297,7 @@ export function renderIndexPage(data: PageData): string {
</label>
</div>
</section>
</div>
<section class="config-section" aria-labelledby="config-sources-title">
<div class="config-section-header">
<h3 id="config-sources-title" class="config-section-title">Sources</h3>
Expand Down
10 changes: 10 additions & 0 deletions web-static/static/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,12 @@ button {
gap: 0.65rem;
}

.config-section-row {
display: grid;
grid-template-columns: repeat(2, minmax(0, 1fr));
gap: 1rem;
}

.config-section-header {
display: flex;
flex-direction: column;
Expand Down Expand Up @@ -894,6 +900,10 @@ body.is-dialog-open {
gap: 0.5rem;
}

:root[data-ui-density="compact"] .config-section-row {
gap: 0.65rem;
}

:root[data-ui-density="compact"] .config-section-header {
gap: 0.2rem;
}
Expand Down