Skip to content

feat: rename "All" filter button to "For You" #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phatpham9 merged 1 commit into from
Jun 23, 2026
Merged

feat: rename "All" filter button to "For You" #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/render.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function sourceIconPath(source: string): string {
function renderFilterButton(filter: SourceFilterView): string {
const activeClass = filter.active ? " is-active" : "";
if (filter.key === "all") {
return `<button class="filter-button${activeClass}" type="button" data-filter="${escapeHtml(filter.key)}" aria-label="${escapeHtml(filter.label)}" title="${escapeHtml(filter.label)}">All</button>`;
return `<button class="filter-button${activeClass}" type="button" data-filter="${escapeHtml(filter.key)}" aria-label="${escapeHtml(filter.label)}" title="${escapeHtml(filter.label)}">${escapeHtml(filter.label)}</button>`;
}
return `<button class="filter-button${activeClass} filter-button--icon" type="button" data-filter="${escapeHtml(filter.key)}" aria-label="${escapeHtml(filter.label)}" title="${escapeHtml(filter.label)}">
<img class="source-icon-image source-icon-image--filter source-icon-image--${escapeHtml(filter.key)}" src="${escapeHtml(filter.iconPath ?? "")}" alt="" aria-hidden="true" />
Expand Down
2 changes: 1 addition & 1 deletion platforms/cloudflare/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ function buildSourceFilters(current: string) {
const defs = [
{
key: "all",
label: "All enabled sources",
label: "For You",
iconPath: undefined as string | undefined,
},
{
Expand Down
3 changes: 1 addition & 2 deletions web-static/static/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
const root = document.documentElement;
const availableSources = ["hackernews", "github", "huggingface", "alphaxiv"];
const sourceLabels = {
all: "All enabled sources",
hackernews: "Hacker News",
github: "GitHub Trending",
huggingface: "Hugging Face Trending Papers",
Expand Down Expand Up @@ -344,7 +343,7 @@
.map((key) => {
const isActive = key === activeFilter;
if (key === "all") {
return `<button class="filter-button${isActive ? " is-active" : ""}" type="button" data-filter="${key}" aria-pressed="${String(isActive)}" aria-label="${escapeAttr(sourceLabels[key] || key)}" title="${escapeAttr(sourceLabels[key] || key)}">All</button>`;
return `<button class="filter-button${isActive ? " is-active" : ""}" type="button" data-filter="${key}" aria-pressed="${String(isActive)}" aria-label="For You" title="For You">For You</button>`;
}
return `<button class="filter-button filter-button--icon${isActive ? " is-active" : ""}" type="button" data-filter="${key}" aria-pressed="${String(isActive)}" aria-label="${escapeAttr(sourceLabels[key] || key)}" title="${escapeAttr(sourceLabels[key] || key)}"><img class="source-icon-image source-icon-image--filter source-icon-image--${escapeAttr(key)}" src="${escapeAttr(sourceIconPaths[key] || "")}" alt="" aria-hidden="true" /></button>`;
})
Expand Down