Project sidecar writer registry#1058
Conversation
|
@codex review |
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (36)
📝 WalkthroughWalkthrough
ChangesWriter registry projection
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Sidecar
participant EncryptionAdminServer
participant WriterRegistryStore
Sidecar->>EncryptionAdminServer: GetSidecarState または ResyncSidecar を呼び出す
EncryptionAdminServer->>WriterRegistryStore: DEK と caller node ID で registry 行を取得する
WriterRegistryStore-->>EncryptionAdminServer: registry 行を返す
EncryptionAdminServer-->>Sidecar: WriterRegistryForCaller を返す
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements the remaining Stage 7 §5.5 recovery surface for WriterRegistryForCaller by wiring the WriterRegistryStore into EncryptionAdminServer. Both GetSidecarState and ResyncSidecar now project the writer registry for the caller, returning the decoded LastSeenLocalEpoch for each DEK present in the sidecar. The review feedback correctly points out that returning codes.InvalidArgument when fullNodeID == 0 is misleading for GetSidecarState since it uses the local node's ID, and recommends returning codes.FailedPrecondition or codes.Internal instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Addressed latest-head review finding:
Caller audit:
Validation:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8c99a0a8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed latest-head P2 review finding:
Validation:
|
|
Current head is green and the latest sidecar projection findings have been addressed with tests. @codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Current head already handles the remaining sidecar projection thread:
Verification:
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3acb8331c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b3acb83 to
39142ba
Compare
|
Resolved the latest-head findings in
Caller audit:
Verification:
History/author audit:
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
39142ba to
04bfde5
Compare
|
Rebased the signed stack onto current main |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04bfde58f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
04bfde5 to
e34b4de
Compare
|
Current head: e34b4de Resolved review findings:
Semantic caller audit:
Validation:
History audit:
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e34b4de8a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Current head: a39527d Resolved latest-head findings:
Semantic caller audit:
Validation:
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a39527d37d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if err := e.capabilityProbe(ctx, address, newNodeFullID); err != nil { | ||
| return errors.Wrap(err, "encryption: refuse member before V2 capability confirmation") |
There was a problem hiding this comment.
When the cluster runs without encryption/sidecar configuration, run() still constructs this interceptor because encWiring.cache is defaulted and the default group store exists, so AddVoter/AddLearner now reach this unconditional probe before the previous ActiveStorageKeyID no-op path. A target node with no sidecar reports full_node_id=0/encryption_capable=false, causing membership changes in non-encrypted deployments to fail even though the interceptor should be inert there; gate interceptor construction or this probe on encryption being configured rather than just on the cache existing.
Useful? React with 👍 / 👎.
1 participant
Summary
WriterRegistryForCallerfrom the writer registry inGetSidecarStateandResyncSidecarEncryptionAdminserverValidation
git diff --checkgo test ./adapter -run 'TestEncryptionAdmin_(GetSidecarState|ResyncSidecar)' -count=1 -timeout=240sgo test ./adapter -run TestEncryptionAdmin -count=1 -timeout=300sgo test ./cmd/elastickv-admin -run 'TestEncryption(Status|Endpoint|Sidecar)' -count=1 -timeout=180sgo test ./store ./internal/encryption . -count=1 -timeout=180sgolangci-lint run ./adapter ./store ./internal/encryption . --timeout=5mAuthor: bootjp
Summary by CodeRabbit
新機能
ドキュメント