Conversation
It's very soon to be EOL (ref https://endoflife.date/fedora) and our CI matrix is way too large. Signed-off-by: Colin Walters <walters@verbum.org>
gursewak1997
previously approved these changes
Sep 21, 2026
jeckersb
previously approved these changes
Sep 21, 2026
jeckersb
enabled auto-merge (rebase)
September 21, 2026 22:20
Member
|
wow i didn't knew there's website for this |
Johan-Liebert1
previously approved these changes
Sep 22, 2026
Johan-Liebert1
left a comment
Member
There was a problem hiding this comment.
DCO issues with the second commit, else lgtm
cgwalters
dismissed stale reviews from Johan-Liebert1 and jeckersb
via
September 22, 2026 13:05
d986021
Collaborator
Yeah that's because I clicked the github webui button to add it from the suggestion that @gursewak1997 added, but even though it went to great lengths to tell me that I would be signing off on it I guess it doesn't actually add the sign off line. Moral of the story, don't click the button in the future 😆 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's very soon to be EOL (ref https://endoflife.date/fedora) and our CI matrix is way too large.