Conversation
Selecting systemd-boot with the ostree backend currently reports that bootupd is required without explaining the supported configuration. Point users to the composefs backend while preserving the existing GrubCC error. Closes: bootc-dev#2093 Generated-by: AI
There was a problem hiding this comment.
🟢 Approval recommended
The focused message change accurately reflects documented backend compatibility.
Pull request overview
Clarifies the error shown when systemd-boot is selected with the unsupported OSTree backend.
Changes:
- Adds actionable guidance to use
--composefs-backend. - Preserves the existing GrubCC error.
File summaries
| File | Description |
|---|---|
crates/lib/src/install.rs |
Separates systemd-boot and GrubCC error handling. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cgwalters
approved these changes
Sep 11, 2026
Collaborator
|
Yeah, with stuff like this we really need a workflow that adds a signoff without making a maintainer do a force push, could be a label or |
Collaborator
|
Tried to do that in bootc-dev/infra#261 but didn't succeed yet... |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting
--bootloader systemdwith the ostree backend currently reports only that bootupd is required. The error now points users to--composefs-backend, which is the supported path for systemd-boot. The separate GrubCC error remains unchanged.Closes: #2093
Generated-by: AI
The contributor has not performed an independent human Rust review yet. Local source inspection,
cargo fmt --all -- --check, andgit diff --checkpassed. The targeted test build could not link on this Windows host because Visual C++link.exeis unavailable, so Linux CI is the build verification.