Skip to content

Fix UB on empty section header [] in config file parser #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vprus merged 2 commits into from
May 28, 2026
Merged

Fix UB on empty section header [] in config file parser #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84496cd
Initial plan
Copilot May 28, 2026
caa7b6d
Fix issue #156: reject empty section header [] as invalid syntax, add…
Copilot May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/config_file.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ namespace boost { namespace program_options { namespace detail {
// Handle section name
if (*s.begin() == '[' && *s.rbegin() == ']') {
m_prefix = s.substr(1, s.size()-2);
if (m_prefix.empty())
boost::throw_exception(invalid_config_file_syntax(s, invalid_syntax::unrecognized_line));
if (*m_prefix.rbegin() != '.')
m_prefix += '.';
}
Expand Down
5 changes: 5 additions & 0 deletions test/parsers_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,11 @@ void test_config_file(const char* config_file)
check_value(a2[4], "m1.v1", "1");
check_value(a2[5], "m1.v2", "2");
check_value(a2[6], "m1.v3", "3");

// Test that an empty section header [] is rejected as invalid syntax (issue #156)
const char content_empty_section[] = "gv1 = 0\n[]\nv1 = 1\n";
stringstream ss_empty(content_empty_section);
BOOST_CHECK_THROW(parse_config_file(ss_empty, desc), invalid_config_file_syntax);
}

#if defined(__CYGWIN__)
Expand Down
Loading