Repository navigation
test(daemon): give the early-disconnect daemon 40 s to exit on slow runners - #594
Merged
Merged
Conversation
Owner
Author
|
@coderabbitai full review |
![bompus-ai-review[bot]](https://avatars.githubusercontent.com/u/253635?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows lifecycle job no longer fails when the daemon from the "disconnect before client hello" test (colbymchenry#1356) takes more than 8 s to disappear after it has finished shutting down.
On GitHub's Windows runner the daemon logged its whole shutdown (idle timeout, server close, query pool, lease release,
exit 0) within 0.1 to 0.7 s of the idle timeout, yet its process stayed visible for more than 8 s. The old test failed at 8 s and then waited another 20 s only to report that the process had exited in that window. Two failed runs show it: #592's first attempt and an earlier run on the kernel-port branch (run 40956126896). The same test passes 8 of 8 times at about 1.7 s on an idle local Windows machine (Windows 11, Node 26, a fresh build of this branch's base), so the stall comes from the loaded runner's process teardown, not from the daemon's shutdown code.The test now waits up to 40 s for the exit in a single step. It still catches the bug it was written for, a reaper that never exits, and still prints the daemon log when it times out.
Checks: the test passes on Linux; 8 repeats on Windows pass on the base build (the change only widens the wait). Not covered: why the process lingers on the runner. I did not reproduce it, so that cause is unexplained.
README rows checked: none affected (test-only change).