[oscars-integration] Thread MutationContext through buitlin standard library objects - #5479
Draft
shruti2522 wants to merge 3 commits into
Draft
[oscars-integration] Thread MutationContext through buitlin standard library objects#5479shruti2522 wants to merge 3 commits into
shruti2522 wants to merge 3 commits into
Conversation
shruti2522
force-pushed
the
feat/msb-phase3-builtins
branch
4 times, most recently
from
August 17, 2026 21:29
bd7e085 to
310be44
Compare
shruti2522
force-pushed
the
feat/msb-phase3-builtins
branch
from
August 17, 2026 21:35
310be44 to
f2ddfe2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5478, this PR enforces threading
MutationContextthrough all internal builtins, removing previous temporary fallbacks.Key Changes:
*_inmethods, temporary methods likeJsObject::new_inare gone. Main methods (e.g.,JsObject::new) have absorbed their signatures and now require the context.Defaultfor core objects:StandardConstructors,IntrinsicObjectsandIntrinsicscan no longer useDefault::default(); they must be instantiated viauninit(mc)boa_class) were updated to dynamically fetchcontext.gc_collector()without violating Rust's mutable borrowing rules.&unsafe { boa_gc::MutationContext::global() }to minimize immediate code breakage