chore(__all__): Enable sorting __all__ using isort#890
Draft
lord-haffi wants to merge 3 commits into
Draft
Conversation
Collaborator
Author
|
Unfortunately, this feature is not compatible with black as isort does weird things if the list is too long for a line. |
|
Hi! This was merged and released in |
Resolve the src/bo4e/__init__.py conflict by taking main's generated model index (authoritative on the current model set) and re-running isort with sort_reexports to format __all__. The pre-commit isort hook is pinned to isort 6.0.1, which predates the sort_reexports/black fix this change relies on and would re-mangle __all__; it is skipped here (SKIP=isort). All other hooks run.
Collaborator
Author
|
Tracking PR on isort: PyCQA/isort#2576 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves this question: #884 (comment)