feat: add BO Produkt and degrade BO Tarif to COM Tarif (draft for AG)#1086
Draft
lord-haffi wants to merge 3 commits into
Draft
feat: add BO Produkt and degrade BO Tarif to COM Tarif (draft for AG)#1086lord-haffi wants to merge 3 commits into
lord-haffi wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft — first of two PRs implementing the new
BO Produkt/BO Vertragmodel from the AG HackMD spec. PR 2 (BO Vertrag rework) is intentionally separate and will referenceProdukt.Changes
BO Produkt(standalone/unreferenced for now) with the tariff's identifying/marketing fields promoted up:bezeichnung,beschreibung,sparte,anbieter,zeitraum_vermarktung,zeitraum_belieferbarkeit,vertragskonditionen,website,kundentypen, plus newprodukttypandtarif.BO Tarif→COM Tarif(bo/tarif.py→com/tarif.py, baseTarifinfo→COM), keeping only the pricing-specific fields (regionspreise,dynamische_preisposition_quelle,energiemix,tariftyp,tarifmerkmale,registeranzahl,preisgarantie,berechnungsparameter,tarifeinschraenkung).Produkttypenum (TARIFPRODUKT);Kundentyp.INDUSTRIE;BoTyp.PRODUKTadded,BoTyp.TARIFremoved;ComTyp.TARIFadded.Verification
pytest: 111 passedpylint src/bo4e: 10.00/10 ·mypy: clean (286 files)generate+validate: both pass (addsbo/Produkt.json,com/Tarif.json,enum/Produkttyp.json; removesbo/Tarif.json)Open questions for the AG
COM Tarifno longer inheritsTarifinfo(which stays a BO alongsideTarifkosten/Tarifpreisblatt). Field duplication was accepted; is the hierarchy split acceptable, or shouldTarifinfobe revisited?BO Tariffields were required (no default); all moved/new fields are nowOptional = None. Please confirm this required→optional relaxation.BoTyp.TARIFremoved outright (vs. keeping a deprecated alias).COM Tarif.regionspreisedocstring references adynamischePreispositionfield that does not exist on the class (pre-existing) — reconcile with dynamic-tariff modelling, likely in a later PR.vertragskonditionenintentionally duplicated onProdukt(and laterVertrag) — overridable at contract time, per spec.Out of scope (→ PR 2)
Bündelvertrag removal,
Vertragsstatusreduction,COM Unterschriftremoval,Vertragsteil→Lokationszuordnungreference, and wiringProduktintoVertrag.