Skip to content

proto: Add SKIP_ROWS alias to support legacy API#6066

Merged
akshatsikarwar merged 1 commit into
bloomberg:mainfrom
akshatsikarwar:legacy-proto
Jul 9, 2026
Merged

proto: Add SKIP_ROWS alias to support legacy API#6066
akshatsikarwar merged 1 commit into
bloomberg:mainfrom
akshatsikarwar:legacy-proto

Conversation

@akshatsikarwar

Copy link
Copy Markdown
Contributor

Add legacy alias for SKIP_INTRANS_RESULTS. There is nothing in current code that uses this.

This will be used in forthcoming amalgamation build by having a common protobuf definition.

Signed-off-by: Akshat Sikarwar <asikarwar1@bloomberg.net>

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_resume_logicalsc_generated **quarantined**
noresetgen
comdb2sys_pagesize_generated
ssl_san
consumer_non_atomic_default_consumer_generated **quarantined**
ssl_set_cmd
ssl_dbname
ssl_prefer
sc_downgrade [timeout] **quarantined**
reco-ddlk-sql [timeout] **quarantined**

@mohitkhullar mohitkhullar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akshatsikarwar akshatsikarwar merged commit 5e61ccc into bloomberg:main Jul 9, 2026
4 checks passed
@akshatsikarwar akshatsikarwar deleted the legacy-proto branch July 9, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants