{182998236}: put retry to back of the queue#5962
Conversation
emelialei88
force-pushed
the
feat/verified-retry-back-to-pool
branch
2 times, most recently
from
2d63d21 to
0882371
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
logfill [db unavailable at finish] **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
sql_logfill_autodisable [timeout]
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_resume
consumer_non_atomic_default_consumer_generated **quarantined**
sql_logfill_autodisable [timeout]
emelialei88
force-pushed
the
feat/verified-retry-back-to-pool
branch
from
0882371 to
4b3170f
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_redo [failed with core dumped]
sc_resume_logicalsc_generated **quarantined**
sc_timepart_multiddl_generated
consumer_non_atomic_default_consumer_generated **quarantined**
truncatesc_offline_generated [timeout] **quarantined**
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_resume_logicalsc_generated **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
remotecreate
remotecreate_twopc_generated
truncatesc_offline_generated [timeout] **quarantined**
reco-ddlk-sql [timeout] **quarantined**
emelialei88
changed the title
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
noresetgen
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
reco-ddlk-sql [timeout] **quarantined**
emelialei88
force-pushed
the
feat/verified-retry-back-to-pool
branch
from
4b3170f to
7b68850
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_resume_logicalsc_generated **quarantined**
sp_snapshot_generated
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
reco-ddlk-sql [timeout] **quarantined**
emelialei88
force-pushed
the
feat/verified-retry-back-to-pool
branch
from
7b68850 to
3e87378
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
truncatesc_offline_generated [timeout] **quarantined**
emelialei88
force-pushed
the
feat/verified-retry-back-to-pool
branch
from
03cb28b to
38aa879
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sirace [failed with core dumped]
sc_force [failed with core dumped]
rebuild_table_options [failed with core dumped]
odh_blobs [failed with core dumped]
verify_writes [failed with core dumped]
cinsert_linearizable [failed with core dumped]
maxtable
phys_rep_tiered_firstfile_generated
phys_rep_tiered_nosource_generated
phys_rep_tiered
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sirace [failed with core dumped]
sc_force [failed with core dumped]
verify_writes [failed with core dumped]
odh_blobs [failed with core dumped]
rebuild_table_options [failed with core dumped]
sicountbug [failed with core dumped]
incremental_backup [failed with core dumped]
maxtable
phys_rep_tiered_firstfile_generated
phys_rep_tiered_nosource_generated
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sirace [failed with core dumped]
sc_force [failed with core dumped]
rebuild_table_options [failed with core dumped]
odh_blobs [failed with core dumped]
verify_writes [failed with core dumped]
serial_randtest2 [failed with core dumped]
sicountbug [failed with core dumped]
incremental_backup [failed with core dumped]
maxtable
phys_rep_tiered
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
emelialei88
force-pushed
the
feat/verified-retry-back-to-pool
branch
from
38aa879 to
69601ad
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_resume
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_truncate_multiddl_generated [db unavailable at finish] **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**
truncatesc_offline_generated [timeout] **quarantined**
2 participants
Summary:
What it does:
srs_tran_replay_int(which looped retries on the same thread) intosrs_tran_replay_prepare(dispatches to the thread pool) andsrs_tran_replay_once(executes a single retry attempt).done_cb_evbuffer, the current worker releases the client back to the pool (RC_INTERNAL_RETRY) instead of blocking while retrying.sqlengine_work_appsockand can itself re-dispatch if another retry is needed — each retry gets a fresh thread from the queue.Why: