Repository navigation
Conversation
govulncheck reports 31 reachable advisories at go 1.26.0 with compress v1.18.7, and none after these two bumps.
No check read the Go advisory database, so 31 reachable advisories stayed on main while every check was green.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
🤖 Reviewed by Jash’s AI agent (Codex) at 81c9b4b. No blocking issue found in the full six-file diff. The workflow uses pull_request and main pushes, read-only contents permission, SHA-pinned actions and checkout without persisted credentials. The executable script is connected to a phony Make target; scanner failures remain nonzero, and the new check deliberately stays outside all-green. The go.mod/go.sum changes match the prerequisite #349; retain the documented merge order. Suggestion — scripts/check-vulnerabilities.sh:47–52: distinguish a scanner execution error from an actual vulnerability finding. Every nonzero exit currently prints “Reachable vulnerabilities found” and recommends a dependency bump, including failures to load packages or fetch advisory data. Preserve the original status and print a scan-failed diagnostic for operational errors; this does not currently create a false-green result. Validation: bash -n passed on the script extracted from this PR diff. A local stub harness exercised scanner exits 0, 1 and 3: the wrapper returned 0, 1 and 1 respectively, confirming both fail-closed behavior and the shared diagnostic above. This was not a real govulncheck run or repository test suite. At review time, 10 GitHub checks passed, including Vulnerability Scan, and seven database/Supabase checks were still running. Exact-head surrounding Makefile retrieval failed with an api.github.com connection error, so context outside the diff was not independently verified. The separate Codex review bot reported a usage-limit failure. |
JashLal
left a comment
There was a problem hiding this comment.
🤖 Approved by Jash’s AI agent (Codex). Review findings and validation limits are recorded in my substantive PR comment.
Add a
Vulnerability Scancheck that runs govulncheck on every pull request and fails when pg-sprite calls into a known vulnerability.Why
No pg-sprite check reads the Go vulnerability database.
mainbuilds on Go 1.26.0 and calls into 31 known vulnerabilities: 30 in the standard library and 1 in klauspost/compress. Lint, the tests and the smoke test all stayed green, so nobody was told. A manual govulncheck run is the only thing that shows them today.What
scripts/check-vulnerabilities.sh. It runs govulncheck v1.6.0 and fails only on findings the code can reach.make check-vulnerabilities, which runs the script, and list it indocs/testing.md.Vulnerability Scanworkflow. It runs that target on pull requests and on pushes tomain.The scan is a workflow of its own and stays out of
all-green. The advisory database changes without any commit here, so a failure is usually not caused by the diff that triggered it.This branch is stacked on #349, the Go 1.26.11 and klauspost/compress bump, so the new check passes here. The
go.modandgo.sumchanges in the diff belong to that PR and drop out once it merges and this branch is updated frommain. Merge #349 first: without it the new check fails onmain.Before / after
CI gains one check.
ci.yml,all-greenand the Go code are unchanged. The example is a pull request opened againstmaintoday, whilego.modstill saysgo 1.26.0.Once the Go and klauspost/compress bumps merge, the same run finds nothing reachable and the check is green.
References
🤖 Generated with Amp (claude-opus-5-5)