Nested sourced from acceptance test cleanup - #1311
Merged
ellisandrews-toast merged 6 commits intoJul 23, 2026
Merged
Conversation
ellisandrews-toast
requested review from
BrianSigafoos-SQ,
bsorbo,
jwils,
jwondrusch,
marcdaniels-toast,
myronmarston and
rossroberts-toast
as code owners
July 16, 2026 18:02
myronmarston
approved these changes
Jul 22, 2026
myronmarston
left a comment
myronmarston
left a comment
Collaborator
There was a problem hiding this comment.
Looking good! I left a couple more suggestions that would be good to include when you merge.
…f __nested_sourced_data guard, use incomplete-document terminology
ellisandrews-toast
enabled auto-merge (squash)
July 23, 2026 16:03
ellisandrews-toast
deleted the
nested-sourced-from-acceptance-test-cleanup
branch
July 23, 2026 16:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the review threads on #1252 that remained open after it merged, specifically pertaining to the acceptance tests.
This fills the coverage gaps identified in review — mostly around the
__nested_sourced_databuffer's edge cases — and reworks the spec for readability, so that every detail a test's assertions depend on is visible in the test body rather than hidden in helper defaults.