Extract shared casing helpers - #1309
Merged
Merged
Conversation
myronmarston
requested changes
Jul 15, 2026
- Move `TypeReference#to_title_case` into `Support::Casing.to_title`. - Document how `to_snake` and `to_upper_snake` differ beyond upcasing (acronym splitting and the leading underscore), with spec coverage of the exact inputs where they diverge. - Cover digit handling (the `\d` in `to_upper_snake`'s regex) and UPPER_SNAKE_CASE inputs across all the conversion methods.
`HasIndices#to_field_name` downcased a type name's leading capital inline. Move that into `Support::Casing.uncapitalize` (the mirror of the capitalization inside `to_title`) so all identifier casing manipulation lives in one place.
jwils
marked this pull request as ready for review
July 15, 2026 17:13
jwils
requested review from
BrianSigafoos-SQ,
bsorbo,
ellisandrews-toast,
jwondrusch,
marcdaniels-toast and
rossroberts-toast
as code owners
July 15, 2026 17:13
myronmarston
requested changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Casing conversions currently live behind private schema-artifact helpers, while protobuf generation needs the same shared behavior.
What
ElasticGraph::Support::Casingwith snake, camel, and upper-snake conversionsRisk Assessment
Low — existing behavior is preserved, and the affected gem suites retain 100% line and branch coverage.
References
Update Jul 15, 15:54 CDT: Addressed casing review feedback
__typename.