fix(desktop): paint full-height community rail to close traffic-light gaps - #3439
Closed
bradhallett wants to merge 1 commit into
Closed
fix(desktop): paint full-height community rail to close traffic-light gaps#3439bradhallett wants to merge 1 commit into
bradhallett wants to merge 1 commit into
Conversation
… gaps PR block#2972 moved the community rail's traffic-light clearance from padding inside the painted element to margins outside it. CSS margins are transparent, so the parent's --background showed through beside the --sidebar-painted rail: a ~56x41px gap at the top (traffic-light band) and ~56x8px at the bottom. The mismatch was visible in every dark theme. Wrap the rail in a full-height bg-sidebar surface that owns the width, z-index, and flex column; the inner <nav> retains its mt/mb so the intended geometry is unchanged. Adds an E2E regression test asserting paint ownership of both gaps under a dark theme (dracula). Signed-off-by: Brad Hallett <53977268+bradhallett@users.noreply.github.com>
Author
|
Closing as superseded by #3382 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since v0.5.0 (#2972), differently-colored blocks appear above and below the community rail in every dark theme. The rail paints
--sidebar, but the surrounding blocks show--background.Root cause
#2972 moved the macOS traffic-light clearance from padding inside the painted
<nav>to margins outside it. CSS margins are transparent, so the parent's--backgroundshows through beside the--sidebar-painted rail:mb-2)At Retina 2× these are ~112 × 82 and ~112 × 16 physical px — large enough to read as distinct color blocks in every dark theme, where
--backgroundand--sidebarare perceptually distinct.Fix
Wrap the rail in a full-height
bg-sidebarsurface that owns the width, z-index, and flex column. The inner<nav>retains itsmt/mb, so the intended geometry (rail-to-content alignment, traffic-light clearance, bottom spacing) is unchanged — only paint ownership moves to the wrapper.This preserves the alignment improvements from #2972 rather than reverting them.
Test
Extends the existing "clears the macOS traffic lights" E2E test to run under a dark theme (dracula) and assert via
elementFromPointthat the surface owns the paint in both the top and bottom gaps — not just geometry alignment.Verification
just ci— full gate green (fmt, clippy, all unit tests, desktop build, Tauri check, web build, 862 mobile tests)