fix: repoint AppImage .DirIcon at a relative symlink - #3436
Open
1nderboi wants to merge 1 commit into
Open
Conversation
tauri-bundler creates .DirIcon at the AppDir root as a symlink to the build machine's absolute AppDir path (e.g. /__w/buzz/buzz/desktop/src-tauri/target/release/bundle/appimage/Buzz.AppDir/Buzz.png), unlike the other bundled icon symlinks which are correctly relative. That path never exists on an end user's machine, so desktop integration tools that resolve .DirIcon to show or install the app icon fail with "Symlink target not found" (block#3419). Fix .DirIcon in fix-appimage.sh, the existing post-build AppImage patch script, by repointing it at its target's basename as a relative symlink within the AppDir. Signed-off-by: 1nderboi <201919958+1nderboi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3419. The AppImage's
.DirIconis a symlink tauri-bundler creates pointing at the build machine's absolute AppDir path (e.g./__w/buzz/buzz/desktop/src-tauri/target/release/bundle/appimage/Buzz.AppDir/Buzz.png), unlike the other bundled icon symlinks (usr/share/icons/.../buzz-desktop.png,usr/share/applications/Buzz.desktop) which are correctly relative. That path never exists on a user's machine, so desktop integration tools that resolve.DirIconto show/install the app icon fail with "Symlink target not found" — confirmed directly from the reporter's screenshots on the issue.desktop/scripts/fix-appimage.sh, the existing post-build AppImage patch script that already handles other tauri-bundler/linuxdeploy quirks (Mesa/GLib/GStreamer conflicts) — same fail-loudly guard pattern as its existing checks, so a future bundler layout change surfaces here instead of shipping silently broken.tauri.conf.json— itsiconlist is already relative; this is purely a bundler-generated artifact.Test plan
bash -n desktop/scripts/fix-appimage.sh— syntax-checks clean.DirIconsymlink → relative symlink that correctly resolves)linux-canary.yml/release.yml) to confirm end-to-end, since building isn't practical in this dev environment🤖 Generated with Claude Code