Repository navigation
Refresh global search with inline settings and plugins - #1331
klopez4212 wants to merge 6 commits into
Conversation
Co-authored-by: Terp <5856f6900e8e0a4e0ea1f4f8d2ee33e4753d2119bc122f94ecafc660b46c0511@buzz.block.builderlab.xyz> Signed-off-by: klopez4212 <klopez4212@gmail.com>
Co-authored-by: Terp <5856f6900e8e0a4e0ea1f4f8d2ee33e4753d2119bc122f94ecafc660b46c0511@buzz.block.builderlab.xyz> Signed-off-by: klopez4212 <klopez4212@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a43acbb13a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {plugin.manifest.id === "buzz.channels" ? ( | ||
| <PreferenceRow |
There was a problem hiding this comment.
When the buzz.channels plugin matches the query, this branch renders only a “Required” span, but controlDestination.run can activate only a switch or combobox. Consequently, clicking this highlighted result—or selecting it with Enter or its numeric shortcut—silently does nothing; either provide a navigation action for the required plugin or omit the row from selectable destinations.
AGENTS.md reference: AGENTS.md:L46-L50
Useful? React with 👍 / 👎.
| const pluginRows = | ||
| plugins && pluginState?.configuration.status === "ready" | ||
| ? pluginState.configuration.catalog.plugins |
There was a problem hiding this comment.
When configuration.status is "recovery"—for example after invalid browser plugin settings or an initial catalog read failure—this condition produces no plugin rows, while the notice below handles neither configuration.reason nor a recovery action. The Plugins group therefore disappears and a search for plugins looks like an ordinary empty search instead of exposing the persistent failure; retain a recovery notice and route or retry action for this state.
AGENTS.md reference: AGENTS.md:L126-L134
Useful? React with 👍 / 👎.
Co-authored-by: Terp <5856f6900e8e0a4e0ea1f4f8d2ee33e4753d2119bc122f94ecafc660b46c0511@buzz.block.builderlab.xyz> Signed-off-by: klopez4212 <klopez4212@gmail.com>
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
🤖 Star Lord’s automated source review via Wes’s account, with independent Rocket (systems/lifecycle), Mantis (correctness/security/concurrency), and Groot (product/accessibility) coverage.
Reviewed head a43acbb13a61b0a4f84b784ade1569f0e7db91cc against base/merge-base 7d50425b7fda7c0bfdccb897df0507a286d6bbac. Overall: 7/10 pending the three concrete fixes inline. Shared Dialog ownership, observer cleanup, persistence services and busy guards are preserved.
P2 — Replace internal media links in the public description. The final “Snapshots” paragraph links two authenticated internal-workspace media resources. Public readers cannot use those review artifacts, and the links expose the internal workspace host and resource identifiers. Remove those links and attach reviewed, sanitized images directly to GitHub. I inspected both images: they show the settings/plugins search UI, without visible personal data or secrets. This finding concerns the published links, not contributor attribution.
Optional: focus the destination setting’s control after its visual highlight; consolidate shared notification-save errors or give repeated retry buttons distinct names; explain when a notification switch is disabled because desktop alerts are off. These are follow-up usability improvements.
Validation: source and attached-image inspection only; no PR code, tests, builds or app launches were executed. One hosted-check snapshot showed failures in Browser measurements and Chromium/WebKit browser-journey shard 8/9, with other jobs still running; failure logs were not inspected, so this review does not attribute those failures. Rendered focus, screen-reader behavior, both themes, narrow/wide/enlarged-text layout, native plugin enable/disable and human acceptance remain unverified. No test-cost measurements or flake-elimination claim. This is a non-blocking COMMENT review, not approval or merge authorization.
Co-authored-by: Terp <5856f6900e8e0a4e0ea1f4f8d2ee33e4753d2119bc122f94ecafc660b46c0511@buzz.block.builderlab.xyz> Signed-off-by: klopez4212 <klopez4212@gmail.com>
Co-authored-by: Terp <5856f6900e8e0a4e0ea1f4f8d2ee33e4753d2119bc122f94ecafc660b46c0511@buzz.block.builderlab.xyz> Signed-off-by: klopez4212 <klopez4212@gmail.com>
Co-authored-by: Terp <5856f6900e8e0a4e0ea1f4f8d2ee33e4753d2119bc122f94ecafc660b46c0511@buzz.block.builderlab.xyz> Signed-off-by: klopez4212 <klopez4212@gmail.com>
2 participants
Search now includes inline appearance, notification, and plugin controls. Settings rows open their owning page and briefly highlight the setting; trailing controls remain editable without closing search.
Refines the palette with an unframed stable input, aligned 12px rows, 24px section gaps, immediate hover feedback, animated content height, and a small scroll-edge fade. Empty search omits Actions. Results are capped at 55vh, and late message matches stay below destination groups.
Validation: TypeScript, design checks/build/tests, search regression tests, and browser checks for navigation, inline controls, spacing, and scroll reachability. Live plugin enable/disable was not exercised. Final human acceptance of the latest behavior is pending.