Repository navigation
fix(apps): use app-bound sharing grant preflight - #33
Merged
Merged
Conversation
torstenrudolf
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sharing an app from a Buzz remote agent should depend on owning the app and being allowed to share it with the target workspace. Today,
bl apps share grantcan fail before it attempts the grant because its preliminary access check uses ordinary app-management credentials, whose workspace can change with the owner's latest session.For example, an app created in Personal can become unshareable from the agent after the owner uses BuilderLab in another workspace. The preliminary check returns
workspace_mismatch, even though the owner still owns the app and is allowed to share it with the chosen team.Use the existing owner/app/destination-bound sharing endpoint to read the lifecycle and revision needed to create the grant, matching how revoke already works. This removes the dependency on the ordinary credential's selected workspace. The server still checks ownership, target eligibility, restricted visibility and the current revision when applying the grant.
This fixes sharing an already restricted app. It does not change visibility automatically or fix workspace selection for ordinary app management; that broader work remains in BOT-2418.