Skip to content

feat(berdctl): select Auto modes for child chats - #431

Open
kyledef wants to merge 1 commit into
mainfrom
kdefreitas/child-auto-balance
Open

kyledef wants to merge 1 commit into
mainfrom
kdefreitas/child-auto-balance

Conversation

@kyledef

@kyledef kyledef commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Let child Berd chats explicitly use Auto Balanced or another configured Auto mode through berdctl session create --auto-mode-id <id>. Today, CLI creation uses the Auto default only when harness, model, and persona are all omitted. There is no way to request a mode explicitly.

berdctl info models --harness-id goose now lists Auto modes separately from concrete models. Creation and session metadata report auto_mode_id. Invalid modes and model/harness conflicts fail before workspace or session creation. Existing default behavior stays unchanged; this does not infer settings from the parent chat.

The change preserves the configured provider/model requirement in LAWS/AGENTS.md and the existing first-message queue path in LAWS/CHAT.md.

Related issue

No duplicate found. Extends the Auto model modes introduced in #389.

Testing

Built the berdctl binary and checked session create --help and info models --help; both expose the new mode selection and discovery guidance. No live desktop end-to-end test. The change adds no new UI.

@kyledef
kyledef marked this pull request as ready for review October 25, 2026 23:00
@kyledef
kyledef requested a review from a team October 25, 2026 23:00

@morgmart morgmart left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Automated code review

Recommend APPROVE. The exact three-dot comparison was reviewed through all four required lenses with no publishable findings and no duplicate threads. Supplied GitHub evidence was inspected separately: Frontend checks and unit tests is failed and Tauri Rust checks (macOS) is in progress, so required checks still govern merge readiness.

Deterministic publication result: 0 blocking and 0 non-blocking inline finding(s) publishable; 0 duplicate(s) suppressed; 0 blocking screenshot-evidence requirement(s) in this review body.

Completed checks currently reporting failure:

  • Frontend checks and unit tests: failure

Pending checks: 2 check(s) are not complete.

This approval reflects the completed code review only; merge readiness remains governed by the repository's required checks.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants