feat: add multiplayer profile images next to fields#1265
Open
jeremydw wants to merge 3 commits into
Open
Conversation
- for multiplayer mode, show the profile image of all users who have a field focused next to the field itself - also tune the focused/highlighted behavior to remove some of the padding - improve the highlighted styles of drawers - linkify the field title instead of the hidden "#" to make it easier to access
…port to clear selection
Member
Author
|
/preview |
Contributor
rootjs.dev PreviewPreview URL: https://rootjs-dev--pr-1265-awri5kbw.web.app This preview is built from the PR head and expires in 2 days. |
Member
|
thanks, this is pretty cool. a couple of notes:
|
- polish deeplink behavior - desaturate inactive icons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR slightly improves the "multiplayer" UI by adding profile images adjacent to the field each person is using.