[BRE-1832] refactor(bitwarden-devops-engineer): manual git ops#151
[BRE-1832] refactor(bitwarden-devops-engineer): manual git ops#151fntyler wants to merge 3 commits into
Conversation
[BRE-1832](https://bitwarden.atlassian.net/browse/BRE-1832) Remove auto-approved git add/commit/push from the action-remediate and workflow-fix skills so these mutating operations are run manually by the user. * Drop `git add`/`git commit`/`git push` from skill `allowed-tools` * Present commands for manual run, then create the draft PR after push * Retarget the diff-confirmation rule to the hand-off step * Bump plugin to 0.1.4 with CHANGELOG and README catalog updates
Plugin Validation Summary —
|
| File | Result |
|---|---|
.claude-plugin/plugin.json |
✅ Pass |
CHANGELOG.md |
✅ Pass |
skills/action-remediate/SKILL.md |
✅ Pass |
skills/workflow-fix/SKILL.md |
✅ Pass |
1. Plugin structure (plugin-validator) — ✅ Pass
- Manifest (
plugin.json): valid JSON;namekebab-case,version0.1.4is valid semver; all fields well-formed, no unknown fields. - Version/name consistency:
0.1.4matches acrossplugin.json(line 3),marketplace.json(lines 61–64), andCHANGELOG.md(line 8). Name consistent everywhere. - CHANGELOG: Valid Keep a Changelog format;
## [0.1.4] - 2026-06-23entry under a proper### Securitycategory, descending version order. - Auto-discovery: Compliant skills-only plugin layout (
skills/<name>/SKILL.md).README.mdpresent. No stray artifacts. - Credentials: None found.
Errors: 0 · Warnings: 0
2. Skill review (skill-reviewer) — ✅ Pass
- Both changed skills have valid frontmatter (
namematches directory,descriptionpresent with two<example>blocks each), strong third-person/imperative descriptions, and are appropriately lean (~500–600 words; no over-engineered progressive disclosure needed). - All cross-skill references resolve:
action-audit,workflow-audit, andbitwarden-workflow-linter-rulesall exist in the same plugin with matchingnamefields. - Skill bodies correctly align with the reduced
allowed-tools:git add/commit/pushare presented as manual user commands (action-remediate Step 3, workflow-fix Step 7) rather than executed.
Errors: 0 · Warnings: 2 (minor, non-blocking)
Minor suggestions (not required for merge):
skills/workflow-fix/SKILL.md:67— thestep_pinnedexception invokesgh api; ensure the procedure documented inbitwarden-workflow-linter-rulesuses thegh api --method GETform so it matches theallowed-toolsallow-list (line 17) and is not denied at runtime.skills/workflow-fix/SKILL.md:5-6vs:47— the description says "Run the workflow-audit skill first," while the body offers to run the linter automatically if the user didn't. Consider aligning the wording.
3. Security review (reviewing-claude-config) — ✅ Pass
- Secrets/credentials: None. All
git/ghexamples use placeholders only. - No committed
settings.local.json. - Permission scoping —
action-remediateline 18:Read, Edit, Glob, Grep, Bash(gh pr create:*), Bash(git checkout:*), Bash(git diff:*). Mutatinggit add/commit/pushcorrectly removed. Remaining Bash perms are read-only or branch setup. ✅ Intent of PR confirmed. - Permission scoping —
workflow-fixline 17:Read, Edit, Glob, Grep, Skill, Bash(bwwl:*), Bash(gh api --method GET *), Bash(git checkout:*), Bash(git diff:*), Bash(git status:*), Bash(gh pr create:*). Mutating git ops correctly removed;gh apiconstrained to read-only--method GET. ✅ Intent of PR confirmed. - No dangerous auto-approvals: no
Bash(*)wildcard, no overly broad file access. Both skills enforce "Only modify files under.github/" in their Rules.
Critical: 0 · Major: 0 · Minor: 0
Verdict
APPROVE — All required checks pass. The version bump (0.1.4) and changelog entry are present and consistent, the allowed-tools changes correctly reflect the stated intent of removing auto-approved mutating git operations, and no security issues were found. The two skill-review warnings are minor polish items and do not block merge.
🤖 Bitwarden Claude Code ReviewOverall Assessment: REQUEST CHANGES This PR removes the auto-approved Code Review Details
|
| ```bash | ||
| git add .github/ | ||
| git commit -m "Remediate <action-name> action usage" | ||
| git push -u origin fix/action-remediation-<action-name-slug> | ||
| ``` |
There was a problem hiding this comment.
⛏️ If the user is now responsible for manually committing and pushing, is this inline bash necessary?
There was a problem hiding this comment.
I think this is a valid point. There is ambiguity here. I'll revisit this to be a bit more explicit with the intent. 👍
There was a problem hiding this comment.
I'm good with these changes, thoughts @SaintPatrck?
Thanks for the work to improve the plugin @fntyler!
🎟️ Tracking
BRE-1832
📔 Objective
Remove auto-approved git add/commit/push from the action-remediate and workflow-fix skills so these mutating operations are run manually by the user.
git add/git commit/git pushfrom skillallowed-tools