Repository navigation
Add opt-in mux WebSocket transport for logger-cli - #755
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reflejo
approved these changes
Nov 19, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The WebSocket transport drops configured API path prefixes and fails to flush Close replies, breaking path-prefixed deployments and leaving server-initiated closing handshakes incomplete.
2 open issues
What changed in this PR
Adds an opt-in WebSocket transport for logger-cli’s mux connection through bd-hyper-network, while keeping gRPC as the default and other HTTP requests unchanged.
Changes:
- Adds a feature-gated WebSocket transport with authentication headers, binary messaging, and size and timeout limits.
- Exposes
--transport websocket, documents usage, and adds transport-selection and connection tests. - Wires WebSocket dependencies and feature variants into Cargo and Bazel.
| File | Description |
|---|---|
logger-cli/src/logger.rs |
Selects the network implementation from the transport option. |
logger-cli/src/driver_test.rs |
Keeps existing driver fixtures on gRPC. |
logger-cli/src/cli.rs |
Adds and forwards the transport flag. |
logger-cli/src/cli_test.rs |
Tests default gRPC and explicit WebSocket selection. |
logger-cli/README.md |
Documents WebSocket usage and transport scope. |
logger-cli/Cargo.toml |
Enables the network crate’s WebSocket feature. |
logger-cli/BUILD.bazel |
Selects the WebSocket-enabled network target. |
Cargo.toml |
Adds the workspace WebSocket dependency. |
Cargo.lock |
Records WebSocket dependencies and resolved versions. |
bd-hyper-network/src/websocket.rs |
Implements WebSocket connection setup and stream forwarding. |
bd-hyper-network/src/websocket_test.rs |
Tests handshake headers, binary exchange, closure, and reconnection. |
bd-hyper-network/src/lib.rs |
Exposes the feature-gated WebSocket module. |
bd-hyper-network/Cargo.toml |
Defines optional WebSocket dependencies and TLS support. |
bd-hyper-network/BUILD.bazel |
Adds the WebSocket feature variant and test target. |
Review effort: Balanced
Preserve API base path prefixes and flush the queued reply to a peer Close before notifying mux. Enable the WebSocket feature on the Bazel libtest so Clippy checks the same callback as Cargo. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.