Skip to content

Add opt-in mux WebSocket transport for logger-cli - #755

Merged
mattklein123 merged 3 commits into
mainfrom
mux-websocket-transport
Nov 19, 2026
Merged

mattklein123 merged 3 commits into
mainfrom
mux-websocket-transport

Conversation

@mattklein123

Copy link
Copy Markdown
Contributor

No description provided.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Matt Klein <mklein@bitdrift.io>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The WebSocket transport drops configured API path prefixes and fails to flush Close replies, breaking path-prefixed deployments and leaving server-initiated closing handshakes incomplete.

2 open issues
What changed in this PR

Adds an opt-in WebSocket transport for logger-cli’s mux connection through bd-hyper-network, while keeping gRPC as the default and other HTTP requests unchanged.

Changes:

  • Adds a feature-gated WebSocket transport with authentication headers, binary messaging, and size and timeout limits.
  • Exposes --transport websocket, documents usage, and adds transport-selection and connection tests.
  • Wires WebSocket dependencies and feature variants into Cargo and Bazel.
File Description
logger-cli/​src/​logger.rs Selects the network implementation from the transport option.
logger-cli/​src/​driver_test.rs Keeps existing driver fixtures on gRPC.
logger-cli/​src/​cli.rs Adds and forwards the transport flag.
logger-cli/​src/​cli_test.rs Tests default gRPC and explicit WebSocket selection.
logger-cli/​README.md Documents WebSocket usage and transport scope.
logger-cli/​Cargo.toml Enables the network crate’s WebSocket feature.
logger-cli/​BUILD.bazel Selects the WebSocket-enabled network target.
Cargo.toml Adds the workspace WebSocket dependency.
Cargo.lock Records WebSocket dependencies and resolved versions.
bd-hyper-network/​src/​websocket.rs Implements WebSocket connection setup and stream forwarding.
bd-hyper-network/​src/​websocket_test.rs Tests handshake headers, binary exchange, closure, and reconnection.
bd-hyper-network/​src/​lib.rs Exposes the feature-gated WebSocket module.
bd-hyper-network/​Cargo.toml Defines optional WebSocket dependencies and TLS support.
bd-hyper-network/​BUILD.bazel Adds the WebSocket feature variant and test target.

Review effort: Balanced

Comment thread bd-hyper-network/src/websocket.rs Resolved
Comment thread bd-hyper-network/src/websocket.rs Resolved
Preserve API base path prefixes and flush the queued reply to a peer Close before notifying mux. Enable the WebSocket feature on the Bazel libtest so Clippy checks the same callback as Cargo.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues requiring changes to the opt-in WebSocket transport addition.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

@mattklein123
mattklein123 merged commit c6fb4fb into main Nov 19, 2026
8 checks passed
@mattklein123
mattklein123 deleted the mux-websocket-transport branch November 19, 2026 23:52
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants