Repository navigation
team-setup: tidy the checklist layout (BB-225) - #256
Merged
trotterdylan merged 2 commits intoNov 3, 2026
Merged
Conversation
Two-column checklist rows with a fixed-width action column, the step mark level with a fixed-height title line, one primary button plus a link for Claude/Codex, and in-progress panels full width below the row. Merging to bb-plugins main moves the bb-server pin, builds a new bb-server image and stages a restart on every developer's server.
Collaborator
Author
|
Independent review running in bb thread @thread:thr_gbapx4vk7s. — from bb thread thr_um22qdut6h |
Collaborator
Author
Review round 1 (Claude Opus 5.5, at 9a2453e)Owner review required: no — none of the owner-reviewed triggers apply. Suggestions
Tested
— from bb thread thr_gbapx4vk7s |
… open (BB-225) Review round 1 suggestion: the always-truthy fragment added the outer gap (8 px) to the row even with no sign-in in progress.
Collaborator
Author
|
Round 1 suggestion addressed in 068595e:
Re-ran — from bb thread thr_um22qdut6h |
Collaborator
Author
Review round 2 (Claude Opus 5.5, at 068595e)Owner review required: no — none of the owner-reviewed triggers apply. Resolved since round 1
The round 1 approval stands at this head. Tested
— from bb thread thr_gbapx4vk7s |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements BB-225. The Team setup checklist read ragged before setup: row height followed the button, the step circle drifted against the title, the Claude/Codex row was wider than the rest, and the create-project link was styled apart from the sign-in buttons. This makes every row the same shape with the same right edge, the mark level with the title, and the in-progress panels full width beneath the row. Layout only; handlers, state and panels are unchanged.
Classification
no-review: a layout tweak in
plugins/team-setup/app.tsxonly. NobigDecisionsentry's paths matchplugins/team-setup, and nothing in the diff removes or changes what a control does — the Codex control keeps its handler and only loses its button box for a link, and the create-project entry was already a plainsize="sm"button (BB-221).What changes
Stepis a two-column row, both columns top aligned: mark + title + paragraph on the left (min-w-0 flex-1), a fixed-widthw-56action column on the right that every row keeps even when empty. The paragraph no longer runs under the button; a narrow window (<sm) stacks the action under the whole left column.h-8line with the mark wrapped in a matchingh-8box, andStepMark'smt-0.5is dropped, so the circle sits level with the title in rows with and without a button.panelprop onStepand span the full row width under the two columns. The state paragraphs and error lines stay in the left column.CreateProjectEntryis untouched: it already usesButton asChild size="sm", the same size and variant as the sign-in buttons.Testing
npm install --include=dev --legacy-peer-deps --no-audit --no-fund: pass.npm run typecheck: pass.npm test: pass (87 tests, 7 files; in the CI matrix).npm run build: pass (app, server and host bundles).finally): rendered the realChecklistfromapp.tsxwith the builtdist/app.cssat 1280, 720 and 375 px. 32/32 checks passed: equal action-column width and right edge in all 8 rows, the empty "A machine" row keeps the 224 px column, the mark/title centre offset is 0 px in every row, no control is wider than the column or sits under its title, the Claude/Codex row is one primary button plus a link, the done GitHub row shows only an outline "Sign out" and the other done rows are empty, and clicking the Codex link still opens the full-width codex panel (panel left = title left, right = action-column right). The harness was scratch and is not committed.