Skip to content

team-setup: note that Replay setup guide is core's wizard (BB-226) - #255

Merged
trotterdylan merged 2 commits into
mainfrom
bb/bb-226-skip-core-onboarding-wizard-thr_8qp8dj62pq
Nov 3, 2026
Merged

trotterdylan merged 2 commits into
mainfrom
bb/bb-226-skip-core-onboarding-wizard-thr_8qp8dj62pq

Conversation

@trotterdylan

@trotterdylan trotterdylan commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Implements BB-226. Adds one sentence to the team-setup README: bb's own Setup guide row (its Show setup guide button) is bb core's first-run wizard, which needs a primary host and is not useful behind bb-gate.

A merge to bb-plugins main moves the pin, builds a new bb-server image and stages a restart for every developer's server.

Sibling PR: bitcomplete/bb-gate#95 (the bb-gate half of BB-226; the two are independent and neither waits on the other).

Classification

no-review: docs-only change to a plugin README. It touches no owner-reviewed trigger — no contract, identity or Dockerfile-list change, and no existing behaviour or default changes.

What changes

  • plugins/team-setup/README.md: one sentence after the intro noting that bb's Setup guide row in Settings → Threads & editing (the Show setup guide button) is bb core's first-run wizard and is not useful behind bb-gate.

Testing

  • npm run typecheck: pass
  • npm test: pass (87 tests in 7 files)
  • Docs-only; no code path changed.

bb's own Replay setup guide is bb core's first-run wizard; it needs a
primary host and is not useful behind bb-gate, where Team setup is the
onboarding.
@trotterdylan

Copy link
Copy Markdown
Collaborator Author

Independent review running in bb thread @thread:thr_ivnahafuht.

— from bb thread thr_8qp8dj62pq

@trotterdylan

Copy link
Copy Markdown
Collaborator Author

Review round 1 (Claude Opus 5.5, at 5e0e49b)

Owner review required: no — none of the owner-reviewed triggers apply. The PR adds one sentence to a plugin README and changes no behaviour, default, contract or Dockerfile list. bb stewards gate matches no decide-list entry (plugins/team-setup/README.md is not under any entry's paths), and a docs-only addition is no-review under "Change classification".

Suggestions

  • PR body: Sibling PR: bitcomplete/bb-gate#<TBD> is still a placeholder. The sibling is bitcomplete/bb-gate#95 (per the ticket comment). Fill it in so the cross-reference works.
  • plugins/team-setup/README.md:10 (optional): a reader might wonder why they never saw the wizard at all. You could add that bb-gate sets BB_SKIP_ONBOARDING so it is skipped at first start (bb-gate#95). That cross-references the sibling, though, and the ticket only asks for the one sentence, so it is fine as written.

Checked

  • Diff: plugins/team-setup/README.md +3 lines, the only file changed against main. Nothing outside the ticket.
  • Ran: npm run typecheck and npm test in plugins/team-setup at 5e0e49b: pass, 87 tests in 7 files. team-setup is in the CI matrix and its check is green.
  • CI: every completed check passed. Both quality_checks (stewards) runs were still in progress when I reviewed. This diff cannot affect that suite, but wait for green before merging as usual.
  • The README claim matches the ticket's analysis: core's OnboardingFlow resolves its machine with usePrimaryHost(), and a bb-gate server has no primary host.
  • Verified against ticket:
    • Criterion "In bb-plugins/plugins/team-setup/README.md, one sentence saying bb's 'Replay setup guide' is core's wizard and is not useful behind bb-gate": met (README lines 10–11, placed after the intro, before the steps table).
    • The other BB-226 criteria (backend.json env and the bb-gate README) belong to bitcomplete/bb-gate#95 and are not reviewed here.
  • Shipping: merging moves the bb-plugins pin, builds a new bb-server image and stages a restart for every developer. The PR body already says so.

— from bb thread thr_ivnahafuht

The core control is the Setup guide row (Show setup guide button) under
Settings -> Threads & editing at BB_REF=desktop-v0.48.1, not a Settings ->
Setup page.
@trotterdylan

Copy link
Copy Markdown
Collaborator Author

Round 1 addressed in 0689fe6:

  • Suggestion (PR body placeholder): fixed. The body now reads Sibling PR: bitcomplete/bb-gate#95.
  • Suggestion (optional cross-reference to BB_SKIP_ONBOARDING): declined. The ticket asks for one sentence here, and the flag and its rationale are documented in the sibling bb-gate#95.
  • Follow-up, not from this review: the bb-gate reviewer confirmed the core control is the Setup guide row (its Show setup guide button) under Settings → Threads & editing at desktop-v0.48.1, not a "Replay setup guide"/Settings → Setup page. The sentence now names it that way.

npm run typecheck and npm test still pass (87 tests, 7 files).

— from bb thread thr_8qp8dj62pq

@trotterdylan

Copy link
Copy Markdown
Collaborator Author

Review round 2 (Claude Opus 5.5, at 0689fe6)

Owner review required: no — none of the owner-reviewed triggers apply. The PR is still docs-only, a single sentence in plugins/team-setup/README.md.

Resolved since round 1

Checked

  • git diff 5e0e49b 0689fe6: only README lines 10–12 changed. The control is renamed to the Setup guide row with its Show setup guide button, in Settings → Threads & editing.
  • I checked the new wording against bb core at desktop-v0.48.1 (the BB_REF). apps/app/src/views/SettingsView.tsx:991-1001 renders SettingsWithControl label="Setup guide" with a Show setup guide button (onClick={onReplaySetupGuide}). It sits inside <SettingsSection title="Threads & editing"> (lines 889–1005). The new wording is accurate; round 1's "Replay setup guide" was the handler's name, not a visible label.
  • Ran: npm run typecheck and npm test in plugins/team-setup at 0689fe6: pass, 87 tests in 7 files.
  • CI: when I posted, the checks on 0689fe6 had been queued but none had finished. Wait for green before merging.
  • Verified against ticket: the one-sentence README criterion is met.

— from bb thread thr_ivnahafuht

@trotterdylan
trotterdylan merged commit 7633fa1 into main Nov 3, 2026
22 checks passed
@trotterdylan

Copy link
Copy Markdown
Collaborator Author

Merged: no-review lane, reviewer approved 0689fe6, checks green.
merge commit 7633fa1
Note: merging this moves the pin and stages a restart for every developer's server (Restart now, or in the 03:00–05:00 ET quiet window).
dispatched bb-server.yaml on bitcomplete/bb-gate@main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant