Add hc_agent smoke tests and minimal helpers - #34
Draft
binrogithub wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
previewcode path never issues network calls andapplytriggers exactly one outbound request.runs/<run_id>/report.mdso downstream tooling can consume reports.Description
hc_agent.pyimplementingpreview(payload),apply(payload, request_fn=None), aRunStorehelper that writesreport.md, andgateway_run(...)which creates a run and writes a report.tests/test_hc_agent_smoke.pythat usemonkeypatch/unittest.mockand aFakeResponseto exercise the three scenarios required: preview does not callrequests.request, apply callsrequests.requestexactly once, and gateway run writesruns/<run_id>/report.mdunder a provided runstore root.hc_agent.requests.requestto avoid real network I/O and usetmp_pathto isolate filesystem writes.Testing
tests/test_hc_agent_smoke.pywhich ispytest-compatible and ready to run locally or in CI.Codex Task