Add endpoint resolution context and HTTP signer/executor for hc_agent - #23
Draft
binrogithub wants to merge 1 commit into
Draft
Add endpoint resolution context and HTTP signer/executor for hc_agent#23binrogithub wants to merge 1 commit into
binrogithub wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rdsandaom, and expose the resolved endpoint to HTTP executor and signer helpers.Description
hc_agent/core/endpoints.pywhich implementsEndpointContext, merges config and environment (HC_AGENT_REGION,HC_AGENT_BASE,HC_AGENT_BASE_DOMAIN) and loads endpoint overrides from config (endpoints,endpoint_overrides,agent.endpoints) and environment variables prefixed withHC_ENDPOINT_.DEFAULT_TEMPLATESandSERVICE_TEMPLATESto map services to patterns includingrds.{region}.{base}andaom.{region}.{base}with fallbacks to region-less templates.hc_agent/core/http_executor.pyandhc_agent/core/signer.pywhich consume theEndpointContextand resolve service hosts for HTTP requests and signing operations respectively.Testing
Codex Task